search

smartystreets / smartystreets-dotnet-sdk

The official client libraries for accessing SmartyStreets APIs from .Net (C# and CLR-based languages)
https://smartystreets.com/docs/sdk/dotnet
Apache License 2.0
22 stars 20 forks source link

Send Requests async #10

Closed GrzesiekP closed 6 years ago

GrzesiekP commented 6 years ago

Have you been thinking about adding SendAsync method ti IClient? I've made a quick research and the biggest this is, that it would require cutting off .NET 3.5 as it does not support Task.

mdwhatcott commented 6 years ago

See previous discussion: https://github.com/smartystreets/smartystreets-dotnet-sdk/pull/1#issuecomment-257563204

ryanjerskine commented 5 years ago

Any chance this could be revisited? I have a PR ready to go adding Async and dropping 3.5 and 4.0 since they aren't supported anymore.

joliver commented 5 years ago

Typically what we have seen is for those that need direct async support, they simply wrap the synchronous call in a Task and then use the async capabilities of the Task Parallel Library.

ryanjerskine commented 5 years ago

Typically what we have seen is for those that need direct async support, they simply wrap the synchronous call in a Task and then use the async capabilities of the Task Parallel Library.

That doesn't help me with anything. Using Task.Run will just pull another thread from the thread pool and block on that thread (slowing things down even more with the overhead of doing that). I'm wanting async for scalability, not to avoid blocking on a UI thread.

jumpingjackson commented 4 years ago

Yeah i think its pretty silly there is no async api

Fullmight commented 1 year ago

Like, "they simply wrap the synchronous call in a Task"? Git isuses are a weird place for a standup routine, and since we all know that doesn't work it has to be a joke right?

ConnorCallison commented 2 months ago

An API client that only offers unnecessarily blocking calls on network IO does not deserve to be used in production. This is a bare minimum capability I would expect of the smarty SDK.

Its not confidence inspiring that this has been an issue since 2016.