search

smartystreets / smartystreets-go-sdk

The official client libraries for accessing SmartyStreets APIs from Go.
https://smartystreets.com/docs/sdk/go
Apache License 2.0
20 stars 6 forks source link

batch loader offers no way to pass ctx to http clients #15

Closed trashhalo closed 4 years ago

trashhalo commented 4 years ago

our spans for smartystreets are missing http calls because send batch doesnt take a context. Would be nice if possible to add that as an option.

DuncanBeutler commented 4 years ago

We are working on implementing this currently. Thank you for raising this issue!

On Thu, Jul 23, 2020 at 2:18 PM Stephen Solka notifications@github.com wrote:

our spans for smartystreets are missing http calls because send batch doesnt take a context. Would be nice if possible to add that as an option.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/smartystreets/smartystreets-go-sdk/issues/15, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKU3KGTWNTSS52JWB7NERBDR5CLKVANCNFSM4PGCPPJQ .

DuncanBeutler commented 4 years ago

WithContext option is now available for all clients. Examples have been updated to reflect the new method. Let us know if there are any further issues!