search

smartystreets / smartystreets-go-sdk

The official client libraries for accessing SmartyStreets APIs from Go.
https://smartystreets.com/docs/sdk/go
Apache License 2.0
20 stars 6 forks source link

Generic Enrichment Lookups #35

Closed JacobMcKenzieSmarty closed 8 months ago

JacobMcKenzieSmarty commented 8 months ago

Added functionality to the us-enrichment-api to allow for generic lookups that return raw json as a byte slice. This will allow for future data sets to be added without needing to make an immediate change to the SDK.

smartybryan commented 8 months ago

The implementation looks good.
I'm struggling with the name SendGenericLookup; I'm not sure why I don't like the name generic. Maybe SendCommonLookup or SendUniversalLookup Send out a poll in developers-products .

We could also use an example that uses this call. I would create a folder under examples/us-enrichment-api named generic, or common (or whatever name we come up with) and include an example.

smartykent commented 8 months ago

I agree with Bryan in both cases. Some examples would be good. I also wonder if we can just call it SendLookup.