search

smartystreets / smartystreets-python-sdk

The official client libraries for accessing SmartyStreets APIs from Python 2.7 and 3.5
https://smartystreets.com/docs/sdk/python
Apache License 2.0
28 stars 30 forks source link

max_timeout in ClientBuilder seems to be in seconds and not in milliseconds #37

Closed lfreeman closed 1 year ago

lfreeman commented 1 year ago

max_timeout in ClientBuilder seems to be in seconds and not in milliseconds as specified in the docstring of with_max_timeout

https://github.com/smartystreets/smartystreets-python-sdk/blob/7d09f38421e6ad73a2862b412762226bf4c7d28f/smartystreets_python_sdk/client_builder.py#L49

RyanLCox1 commented 1 year ago

This has been changed to reflect that the value is in seconds, not milliseconds. Thank you for pointing it out!