smartystreets / smartystreets-ruby-sdk

The official client libraries for accessing SmartyStreets APIs from Ruby
https://smartystreets.com/docs/sdk/ruby
Apache License 2.0
23 stars 25 forks source link

Client timeout values expressed in incorrect units #12

Closed ghost closed 6 years ago

ghost commented 6 years ago

It seems like the value passed in to the client builder falls right through to Net::HTTP, which interprets that number in seconds:

https://github.com/smartystreets/smartystreets-ruby-sdk/blob/master/lib/smartystreets_ruby_sdk/native_sender.rb#L19

35660413-b2d469fe-06c0-11e8-99db-766346ae2598

That makes the default timeout over two hours 😬

MouaYing commented 6 years ago

@Nathan-Brandless - Yikes! Good catch. We will look into this posthaste.

MouaYing commented 6 years ago

@Nathan-Brandless - A new version (v5.3.0) has just been released, and it includes a fix for this.

Thanks for helping us find this!