Both US Street Client and International Street Client are very similar when it comes to usage.
I thought it was a bit confusing that both of them provide a method aimed to send lookup, however the first one defines it as send_lookup(lookup) while the other one defines it as send(lookup).
Specially when it comes to the international street client, it also feels weird to call client.send(lookup). For someone who's not familiar with the gem, by doing it like this, it gives the impression that we're trying to call a private method name lookup (using the native Object#send) and forgot to use the : to specify lookup as symbol
Would it make sense to rename it to send_lookup, to avoid confusion in both scenarios?
If positive, I would be happy to help with this change.
Both US Street Client and International Street Client are very similar when it comes to usage. I thought it was a bit confusing that both of them provide a method aimed to send lookup, however the first one defines it as
send_lookup(lookup)
while the other one defines it assend(lookup)
.https://github.com/smartystreets/smartystreets-ruby-sdk/blob/bb101606189004725cf56aef77b592eecdc0aaf3/lib/smartystreets_ruby_sdk/us_street/client.rb#L15
https://github.com/smartystreets/smartystreets-ruby-sdk/blob/bb101606189004725cf56aef77b592eecdc0aaf3/lib/smartystreets_ruby_sdk/international_street/client.rb#L14
Specially when it comes to the international street client, it also feels weird to call
client.send(lookup)
. For someone who's not familiar with the gem, by doing it like this, it gives the impression that we're trying to call a private method namelookup
(using the native Object#send) and forgot to use the:
to specifylookup
as symbolWould it make sense to rename it to
send_lookup
, to avoid confusion in both scenarios? If positive, I would be happy to help with this change.