smas1 / geoext-viewer

Automatically exported from code.google.com/p/geoext-viewer
GNU General Public License v3.0
0 stars 0 forks source link

PrintAttribution: false doesn't work #327

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The new PrintAttribution stuff works great.

Except it doesn't seem possible to disable it!
My map output is identical whether I use:
PrintAttribution: false
or
PrintAttribution: true

Also - which should be default? I'd guess False. The printdialog example 
doesn't say.

Original issue reported on code.google.com by jonathan...@warwickshire.gov.uk on 3 Jan 2014 at 1:13

GoogleCodeExporter commented 9 years ago
The default of the PrintAttribution is 'true' - please have a look at 
'PrintPreview.js':
...
    /** api: config[printAttribution]
     *  ``Boolean`` If set to true, the 'mapAttribution' content is given to the print
     *  service for the map attribution - if 'mapAttribution' is set to Null, the map
     *  attributions of the visible layers will be determined and given to the print
     *  service. If set to false, this will disable the map attribution print output.
     *  Default is true.
     */
    printAttribution: true,
...
This behavior is continued in the printdirect and printdialog code.

I've tested both print versions with our app setting the config flag 
'printAttribution' to 'false' - both are working fine?! Could not verify this 
issue.

Original comment by wolfram.winter on 6 Jan 2014 at 11:29

GoogleCodeExporter commented 9 years ago
Ah ok. The bug then is that I was using a capital "P" and JavaScript is case 
sensitive.

PrintAttribution: false - doesn't work

printAttribution: false - does work

It's correct in the demo. I guess I'm naturally biased against caMeLaSe. :-)

My bad! Thanks for checking.

Original comment by jonathan...@warwickshire.gov.uk on 6 Jan 2014 at 1:05