search

smas1 / geoext-viewer

Automatically exported from code.google.com/p/geoext-viewer
GNU General Public License v3.0
0 stars 0 forks source link

Enhanced Drawing Tools #329

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Enhancement of the current basic drawing tools implementation.

This issue is applicable only to redlining, however we're not averse to these 
behaviours also being carried over to other styling functions.

All items as drawn/styled should be printable with that drawn/style.

The user can specify all of the below:

- Ability to style individual features differently. Have a red polygon and a 
blue polygon and a transparent polygon all in the same canvas if wanted. This 
should also carry over to feature types. Along with those polygons, the user 
can also have purple lines, pink lines, oranges, and blue labels, again, all in 
the same canvas as the original polygons.

Detailed list of features:

- Polygons:
    = strokes width
    = stroke colour
    = stroke-dash (optional - with ability to set dash-array type)
    = stroke transparency
    = fill colour
    = fill transparency

- Lines:
    = strokes width
    = stroke colour
    = stroke-dash (optional - with ability to set dash-array type)
    = stroke transparency

- Points:
    = Type of symbols (all OGC/OpenLayers symbols - http://openlayers.org/dev/examples/graphic-name.html )
    = Symbol colour
    = Symbol size
    = Symbol transparency

===

See attached image. Basically all of that should be reproduceable within a 
single canvas in Heron, and then printed on top of the map with MFP.

====
User actions
There will be two possible workflows to let the user do this.
-- User draws features and needs to select them to change the style of them.
-- User sets style, then any features drawn thereafter become that colour (like 
a paint program). Of course they can later change the style using the other 
method.

This is aimed at basic level users, we're ideally hoping for a simple, 
accessible user interface but don't have any particular requirements for what 
it should look like at present.

Original issue reported on code.google.com by jonathan...@warwickshire.gov.uk on 7 Jan 2014 at 5:35

Attachments:

GoogleCodeExporter commented 9 years ago 
Ack. Running example will be at:

http://lib.heron-mc.org/heron/latest/examples/vectorstyler

Use Help [?] button for info and help in example.

Original comment by jus...@gmail.com on 7 Jan 2014 at 9:32

GoogleCodeExporter commented 9 years ago 
Quite some is working now in the example:
http://lib.heron-mc.org/heron/latest/examples/vectorstyler

Most of the requirements in this issue are fulfilled and also for issue 331 
(Styling subsets of data). When trying the example, try all 3 kinds of Vector 
Layers pls:

* Drawing Layer (autoactivated)
* local files loaded (Addresses, Parcels and GPX track) all visible
* WFS layers - not visible, try an overlay like BAG Woonplaatsen WFS 
(City-limits) and try Labeling

What is not yet working and todo:

* Side legend (right) is not updated on Style changes
* Font color/opacity in Label tab is only shown on second invoke
* Drawing Layer: object selection and changing style of selected objects works 
but objects do not display select-color on select
* Label styling in Drawing Layer does not work. This is a deep issue in 
external OL Editor and hard to solve. Strictly, this was also not required in 
the issue description.
* Printing is still todo (will add to example)

Original comment by jus...@gmail.com on 22 Jan 2014 at 12:28

GoogleCodeExporter commented 9 years ago 
Quick observations:
1) The drawing toolbar seems to be in Dutch (or something non-English), while 
the rest of the interface has English.

2) The CSS style for selecting a rule is non-obvious. If I have two Rules it's 
not clear which one is selected and which one isn't.

3) If I removed DrawingLayer from ActiveThemes, then I can never draw anything 
ever again!

4) Can the colour Picker dialog disappear when a colour has been selected? 
After all, there's no point keeping it open.

5) Is it possible to order the colour picker dialog into something logical? 
Currently the colours appear to be randomly sorted.

6) For point rules - The "Symbol" box is when the rule is accessed.

7) The "Symbol:" example doesn't appear until a change has been made to the 
style.

That's just from a quick test. I'll do a more thorough one when it's nearer 
completion.

Looks very good though!

Cheers,
Jonathan

Original comment by jonathan...@warwickshire.gov.uk on 22 Jan 2014 at 2:23

GoogleCodeExporter commented 9 years ago 
Quick observations:
1) The drawing toolbar seems to be in Dutch (or something non-English), while 
the rest of the interface has English.
--> now English

2) The CSS style for selecting a rule is non-obvious. If I have two Rules it's 
not clear which one is selected and which one isn't.
--> improved/visible select-style

3) If I removed DrawingLayer from ActiveThemes, then I can never draw anything 
ever again!
--> my plan is to add a Styler icon to the Drawing Toolbar. In the mean time 
you can get the Drawing Layer back by dis/enabling the Drawing tools..

4) Can the colour Picker dialog disappear when a colour has been selected? 
After all, there's no point keeping it open.
--> Done

5) Is it possible to order the colour picker dialog into something logical? 
Currently the colours appear to be randomly sorted.
--> done, also new color palette

6) For point rules - The "Symbol" box is when the rule is accessed.
--> ?? (not visible?). I see nothing strange (Chrome)

7) The "Symbol:" example doesn't appear until a change has been made to the 
style.
--> cannot reproduce. details?

Original comment by jus...@gmail.com on 23 Jan 2014 at 2:14

GoogleCodeExporter commented 9 years ago 
Excellent, thanks.

6) Sorry, poor explanation. When looking at the Point rule, the drop down menu 
for "Symbol" is empty. It should be pre-populated with the "Circle" style.

7) This seems to be Opera only, so I guess it can be ignored.

8) New one - It really *really* doesn't work well in IE 8. See attached for 
what happens when you open a point Rule. I haven't done anything after opening 
this dialog.

Original comment by jonathan...@warwickshire.gov.uk on 24 Jan 2014 at 11:49

Attachments:

GoogleCodeExporter commented 9 years ago 
8) New one - It really *really* doesn't work well in IE 8. See attached for 
what happens when you open a point Rule. I haven't done anything after opening 
this dialog.
Also in IE10 but only for Fill field, not for Stroke, but strange. Will look 
into.

Original comment by jus...@gmail.com on 24 Jan 2014 at 3:11

GoogleCodeExporter commented 9 years ago 
8) New one - It really *really* doesn't work well in IE 8. See attached for 
what happens when you open a point Rule. I haven't done anything after opening 
this dialog.

Solved: The problem only occurs with "3-digit" hexcolors. Appears to be an 
IE-only problem. When converting to 6-digit hex-colors in GXP-Colorfield the 
string was accessed as array, while charAt() should be used for cross-browser 
compatibility. See also
http://stackoverflow.com/questions/2526019/simple-javascript-string-problem-in-i
e6-and-ie7
Pff, learning JS everyday...Most of the afternoon's time was taken by Windows 
installing 17 updates though...

Original comment by jus...@gmail.com on 24 Jan 2014 at 3:56

GoogleCodeExporter commented 9 years ago 
Hehe - who needs windows updates? :-)

5) - new colour picker looks good, but in IE it looks like attached. Seems to 
be related to the second item of these: 
http://code.google.com/p/geoext-viewer/issues/detail?id=188#c4

8) Yep, works fine now.

Original comment by jonathan...@warwickshire.gov.uk on 24 Jan 2014 at 4:50

GoogleCodeExporter commented 9 years ago 
Forgot to attach this.

Original comment by jonathan...@warwickshire.gov.uk on 24 Jan 2014 at 5:16

Attachments:

GoogleCodeExporter commented 9 years ago 
5) - new colour picker looks good, but in IE it looks like attached. Seems to 
be related to the second item of these: 
http://code.google.com/p/geoext-viewer/issues/detail?id=188#c4

==> Should be solved. Very nasty issue, IE not obeying CSS-rules, had to set 
explicit window size...

Original comment by jus...@gmail.com on 27 Jan 2014 at 3:09

GoogleCodeExporter commented 9 years ago 
I have here as remaining issues:

* Drawing Layer: explicit Styler button, i.s.o. via Layer Context menu as 
Drawing Layer is not always shown
* Drawing Layer: object selection and changing style of selected objects works 
but objects do not display select-color on select
* Printing is still todo (to be added to example)
* Font color/opacity in Label tab is only shown on second invoke

Original comment by jus...@gmail.com on 27 Jan 2014 at 3:13

GoogleCodeExporter commented 9 years ago 
These two issues now solved:

* Drawing Layer: explicit Styler button, i.s.o. via Layer Context menu as 
Drawing Layer is not always shown
* Drawing Layer: object selection and changing style of selected objects works 
but objects do not display select-color on select

See example (try selecting features in editor layer and style them):
http://lib.heron-mc.org/heron/latest/examples/vectorstyler

Remaining:

* Printing is still todo (to be added to example)
* Font color/opacity in Label tab is only shown on second invoke

Original comment by jus...@gmail.com on 30 Jan 2014 at 1:15

GoogleCodeExporter commented 9 years ago 
* Font color/opacity in Label tab is only shown on second invoke
fixed: allow opacity editing and show text symbolizing if data attrs with Layer

Remaining:

* Printing is still todo (to be added to example)

Original comment by jus...@gmail.com on 3 Feb 2014 at 5:43

GoogleCodeExporter commented 9 years ago 
Printing added, now testing...

Original comment by jus...@gmail.com on 4 Feb 2014 at 2:20

GoogleCodeExporter commented 9 years ago 
Hi Just. Looks excellent. A not-short set of feedback below.

- If the users window isn't wide enough, they don't see all of the drawing 
tools. See screenshot. Maybe an auto-wrapping toolbar would fix this?

- When mousing over the "Color" box for style editing, the icon changes to a 
text-cursor ("I"). Should be something else as you can't enter text into the 
box.

- Is there a reason for showing the Hex code of the colours? If the user can't 
manually enter their own codes then I don't see it adding much (there are tools 
out there for determining the code if the user really wants to know it).

- 1) Load page
2) Click "i" (Feature information)

The "toggle" for the drawing tools switches to showing them as being "off". But 
the drawing tools are still on. If I click the drawing-tools icon, the toggle 
shows them as being "on", but the drawing tools panel disappears.

- Toggle Drawing-tools off. Now toggle it on again. When toggled back on, the 
"pan" tool becomes untoggled.

- Is it possible to change the size/shape and color of the mask/buffer that 
surrounds the text?

- Can the Symbol names (circle, square, etc) and style names (das,h etc) all 
begin with a capital letter?

- When a user "duplicates" a style, I'd suggest that the new duplicate name 
have a number after it "2" or "3" or whatever depending on how often they 
duplicate it.

- For DrawingLayers - why is there an "Add" for adding a new rule? Any rule 
added seems to always be a point and somewhat dodgy.
- DrawingLayers probably shouldn't have a "remove" either" Or "Duplicate".

- DrawingLayers - The "Symbol" box isn't pre-populated with the word "circle". 
"Rotation" box should be pre-populated with "0".

- Basic tab - Can "width" be changed to "Width (pixels)" (assuming those are 
the units).

- If I change the point symbol from a circle to something else (a square), the 
cursor under the mouse still shows a circle when I am drawing.

- If "DrawingLayer" is turned off it seems impossible to get it back!

======
Labels
- The "addresses" layer has "Label features" checked, but there are no labels. 
It appears that there is no "label values" set. I'd suggest that untless a 
label values is set, the "label features" be disabled.  And/or some way of 
making it clear to the user that they have to set a "label values" (it's 
mandatory).

- On the labels tab the user-entered font size is greyed out on the labels tab. 
I don't believe it should be (by greying it out it is implying that the user 
can't edit it). It's not greyed out on the "basic" tab.

- 1) Place a label.
2) Select geometry - that label.
3) Click on "Change feature styles"
The label becomes a point and all styling is lost and needs to be re-applied.

======

"Change Feature Styles" issues
-- If no feature is selected it seems to change the style of DrawingLayers in 
general. If this is intended, I'd suggest making it clear that you're either 
(a) Editing the style of an exist feature. Or (b) Editing future styles.

-- When editing a pre-existing, selected feature, I think it should only show 
the rule that is applicable (I.e. the point rule for points, the polygon rule 
for polygons). It'll confuse users otherwise.

-- If I select a feature and change the colour of it, then all new features 
will also be of that colour. I'm not sure if this is desireable. Surely it 
should only change the colour of the specified feature?

- Colour for selected points
1) Draw two points.
2) right click on DrawingLayer - "Edit style layer" - change point colour to 
something else.
3) Now try and use the "select geometry" - cannot select the original two 
points!
Actually you *are* selecting the point, but there's no visual indication 
(they're supposed to change colour).

-- It's only possible to select one feature at once. This makes changing styles 
tedious. Is there away to allow multiple feature selection?

======
Snapping settings
- The "Snapping Layer" has a list of random seeming layers. Is it all suitable 
layers? The list appears to be in the wrong order. It should probably also only 
show layers that are visible.
- The text is slightly misaligned with the checkboxes (all browsers).

Original comment by jonathan...@warwickshire.gov.uk on 4 Feb 2014 at 2:39

GoogleCodeExporter commented 9 years ago

Original comment by jonathan...@warwickshire.gov.uk on 4 Feb 2014 at 2:57

Attachments:

GoogleCodeExporter commented 9 years ago 
An impressive list of comments. Will first try to focus on major ones/real bugs 
and related to drawing tools styling, and answer some obvious ones.

> - 1) Load page
> 2) Click "i" (Feature information)
> 
> The "toggle" for the drawing tools switches to showing them as being "off". 
But the drawing tools are still on. If I click the drawing-tools icon, the 
toggle shows them as being "on", but the drawing tools panel disappears.
> 
SOLVED, the Editor is now a true OL Control (see also next)
> - Toggle Drawing-tools off. Now toggle it on again. When toggled back on, the 
"pan" tool becomes untoggled.
This is as per (OL) design. Many of the buttons in toolbar are mutually 
exclusive where they catch user vents, like the mouse. Only one Control has 
"control" of the Map interaction.

> - For DrawingLayers - why is there an "Add" for adding a new rule? Any rule 
added seems to always be a point and somewhat dodgy.
> - DrawingLayers probably shouldn't have a "remove" either" Or "Duplicate".
Drawing Layers have fixed rules and symbolizers, so all rule management buttons 
should be disabled, or will see if they can be removed.

> - If I change the point symbol from a circle to something else (a square), 
the cursor under the mouse still shows a circle when I am drawing.
> 
This is as per design of OLEditor: any drawing (pt, line, polygons) uses this 
circle symbol for point setting.

> - If "DrawingLayer" is turned off it seems impossible to get it back!
> 
This is as per the behaviour of Active Themes. You should be able to get it 
back via the Overlays. But in general Drawing and Snapping Layers should not be 
in the Layer tree IMO.

> - 1) Place a label.
> 2) Select geometry - that label.
> 3) Click on "Change feature styles"
> The label becomes a point and all styling is lost and needs to be re-applied.
This is a real bug, already noted.

> - Colour for selected points
> 1) Draw two points.
> 2) right click on DrawingLayer - "Edit style layer" - change point colour to 
something else.
> 3) Now try and use the "select geometry" - cannot select the original two 
points!
> Actually you *are* selecting the point, but there's no visual indication 
(they're supposed to change colour).
Also a bug: selecting objects does not work in some scenario's. Seems to have 
to do with the order of drawing and styling.
> -- It's only possible to select one feature at once. This makes changing 
styles tedious. Is there away to allow multiple feature selection?
It _is_ possible to select multiple objects. Have you tried dragging the mouse? 
But I see, that's only for objects in the same rectangle, not random objects. I 
see that shift-click does not work...

> - The "Snapping Layer" has a list of random seeming layers. Is it all 
suitable layers? The list appears to be in the wrong order. It should probably 
also only show layers that are visible.
The Snapping Layer should not be there at all. It is a bit hard to get control 
over that Layer as it is created within OLEditor.

Original comment by jus...@gmail.com on 5 Feb 2014 at 3:36

GoogleCodeExporter commented 9 years ago 
> "An impressive list of comments."
I do try. :-)

> "This is as per design of OLEditor: any drawing (pt, line, polygons) uses 
this circle symbol for point setting."

I did notice that (i.e. for polygons), but it just seems a bit weird when the 
symbol is supposed to be different.

> "It _is_ possible to select multiple objects. Have you tried dragging the 
mouse? But I see, that's only for objects in the same rectangle, not random 
objects. I see that shift-click does not work..."

I did try dragging the mouse, but that pans the map... I also tried using 
"ctrl" key (the standard for selecting multiple things), but that didn't do 
anything either.

Original comment by jonathan...@warwickshire.gov.uk on 5 Feb 2014 at 4:11

GoogleCodeExporter commented 9 years ago 
The following issue-items have been SOLVED:

> - For DrawingLayers - why is there an "Add" for adding a new rule? Any rule 
added seems to always be a point and somewhat dodgy.
Removed for now. Too many issues. Via Duplicate is the best option for now.

> - DrawingLayers probably shouldn't have a "remove" either" Or "Duplicate".
Drawing Layers have fixed rules and symbolizers, so all rule management buttons 
should be disabled, or will see if they can be removed.

--> At least disabled: much GXP code assumes a certain array order of these 
buttons. Removing them will break possibly stuff.

> - Colour for selected points
> 1) Draw two points.
> 2) right click on DrawingLayer - "Edit style layer" - change point colour to 
something else.
> 3) Now try and use the "select geometry" - cannot select the original two 
points!
> Actually you *are* selecting the point, but there's no visual indication 
(they're supposed to change colour).
Also a bug: selecting objects does not work in some scenario's. Seems to have 
to do with the order of drawing and styling.
--> worked before but fix was not properly applied. Should work now.

Still unclear why feature selection via dragging does not work in your case. 
Which browser? Works fine in Chrome+Safari Mac. Will try IE myself.

Original comment by jus...@gmail.com on 6 Feb 2014 at 1:32

GoogleCodeExporter commented 9 years ago 
> Still unclear why feature selection via dragging does not work in your case. 
Which browser? Works fine in 
> Chrome+Safari Mac. Will try IE myself.
Works as well for me in IE (v11 due to Win-selfupgrading, sigh). You use the 
'Select geometry' button first?

Tested printing. tested for Drawing feaures, different styles etc. 2 issues 
found, which are MFP-specific IMO:

1. strokeDashstyle quirks: https://github.com/mapfish/mapfish-print/issues/112. 
Made workaround, so 'dash' works but 'dot' not.

2. three-digit hexcodes like the initial blue give very dark effects. Same 
issue was in GXP ColorPicker, solved, but IMO MFP should understand 3-digit 
hexcodes like #07f .that expand to #0077ff.

Original comment by jus...@gmail.com on 6 Feb 2014 at 4:32

GoogleCodeExporter commented 9 years ago 
Als for for 2nd issue related to printing, MFP issue opened:

https://github.com/mapfish/mapfish-print/issues/113

(btw I have solved only the ColorPicker, not the MFP yet).

Original comment by jus...@gmail.com on 6 Feb 2014 at 4:40

GoogleCodeExporter commented 9 years ago 
> "Still unclear why feature selection via dragging does not work in your case. 
Which browser? Works fine in 
> Chrome+Safari Mac. Will try IE myself."
Ah ok. It seems it's because I was using "modify geometry" rather than "select 
Geometry". The former acts as a form of selecting geometry and so that's what I 
was using it for.

Original comment by jonathan...@warwickshire.gov.uk on 7 Feb 2014 at 1:06

GoogleCodeExporter commented 9 years ago 
Ok, I am looking to finalize this item. There are offcourse small UX issues, 
but AFAICS there is one major bug: when using PrintPreview the Drawing Styles 
are not in the preview not printout. This is not the case of any non-Drawing 
Layer. The cause lies in the fact that the Drawing Layer has per-feature Styles 
while all other Vector Layers have per-Layer Styles. Somewhere Layers and 
features are cloned for the PrintPreview, so there the per feature Styles are 
not (properly) cloned.  Will solve this in coming hours.
Looks like this GeoExt issue:
https://github.com/geoext/geoext2/issues/217

Fixed two bugs:
- feature Style cloning for Drawing Layer when using  PrintPreview
- could not open PrintPreview twice with visible Vector Layers 
Both were GeoExt issues and fixed in geoext-override.js for now.

Original comment by jus...@gmail.com on 17 Feb 2014 at 4:06

GoogleCodeExporter commented 9 years ago 
Sounds good. When you've got that printing issue resolved I'll go through. So 
tomorrow most likely. Thanks again for your work on this.

Original comment by jonathan...@warwickshire.gov.uk on 17 Feb 2014 at 4:28

GoogleCodeExporter commented 9 years ago 
The print-preview issue is resolved (assuming that is the one you meant?)

Original comment by jus...@gmail.com on 17 Feb 2014 at 4:42

GoogleCodeExporter commented 9 years ago 
Hi Just,
So I started by re-resting all of the previously reported ones. Particularly 
important ones marked with ==. ++ Used for ones that should probably be simple.
- If the users window isn't wide enough, they don't see all of the drawing 
tools. See screenshot. Maybe an auto-wrapping toolbar would fix this?
== This is important because we can't assume the screenwidth the user has.

- When mousing over the "Color" box for style editing, the icon changes to a 
text-cursor ("I"). Should be something else as you can't enter text into the 
box.

- Is there a reason for showing the Hex code of the colours? If the user can't 
manually enter their own codes then I don't see it adding much (there are tools 
out there for determining the code if the user really wants to know it).

- Is it possible to change the size/shape and color of the mask/buffer that 
surrounds the text?

- Can the Symbol names (circle, square, etc) and style names (das,h etc) all 
begin with a capital letter?
++Not important, but should be easy, no?

- When a user "duplicates" a style, I'd suggest that the new duplicate name 
have a number after it "2" or "3" or whatever depending on how often they 
duplicate it.

- DrawingLayers - The "Symbol" box isn't pre-populated with the word "circle". 
"Rotation" box should be pre-populated with "0".
==This may confuse users, at least the symbol one likely will.

- Basic tab - Can "width" be changed to "Width (pixels)" (assuming those are 
the units).
++

------------
Labels
- The "addresses" layer has "Label features" checked, but there are no labels. 
It appears that there is no "label values" set. I'd suggest that untless a 
label values is set, the "label features" be disabled.  And/or some way of 
making it clear to the user that they have to set a "label values" (it's 
mandatory).

- On the labels tab the user-entered font size is greyed out on the labels tab. 
I don't believe it should be (by greying it out it is implying that the user 
can't edit it). It's not greyed out on the "basic" tab.

- 1) Place a label.
2) Select geometry - that label.
3) Click on "Change feature styles"
The label becomes a point and all styling is lost and needs to be re-applied.
== You acknowledged it in your response, but I don't think a fix has been 
implemented as it's still happening.

------------
(New issues)
Printing
- The colours used in printing seem to be different from the ones used on the 
page. This appears to be an opacity issue (100% opacity they come through 
correctly). Look at the "Address point" layer on-screen and on the print for 
exmaple.

== The print legend is empty when I add it. It should be populated like the 
Heron one.

== Labels show up as points in print preview!
== Labels print as points when done through print preview!
(I suspect these last two relate to that bug you just referenced).

Original comment by jonathan...@warwickshire.gov.uk on 17 Feb 2014 at 5:13

GoogleCodeExporter commented 9 years ago 
Most if not all functionalities/bugs were outside Heron, mainly in GXP 
(indicated as GXP) and some in GeoExt and OpenLayers.
I have made the most important fixes. There are left-overs "GXP" that I would 
rather move to a subsequent issue. 

> - If the users window isn't wide enough, they don't see all of the drawing 
tools. 
> See screenshot. Maybe an auto-wrapping toolbar would fix this?
> == This is important because we can't assume the screenwidth the user has.
Is solved in issue 337 thanks to Wolfram!

> - When mousing over the "Color" box for style editing, the
> icon changes to a text-cursor ("I"). Should be something else as you can't 
enter text into the box.
GXP

> - Is there a reason for showing the Hex code of the colours?
>  If the user can't manually enter their own codes then I don't see it adding 
much (there are tools out there for determining the code if the user 
> really wants to know it).
GXP

> - Is it possible to change the size/shape and color of the mask/buffer that 
surrounds the text?
Not interactively but via Vector Layer Style config.

> - Can the Symbol names (circle, square, etc) and style names (das,h etc) all 
begin with a capital letter?
> ++Not important, but should be easy, no?
Done

> - When a user "duplicates" a style, I'd suggest 
> that the new duplicate name have a number after it "2" or "3" or whatever 
depending on how often they duplicate it.
GXP

> - DrawingLayers - The "Symbol" box isn't pre-populated with the word 
"circle". "Rotation" box should be pre-populated with "0".
> ==This may confuse users, at least the symbol one likely will.
Fixed

> - Basic tab - Can "width" be changed to "Width (pixels)" (assuming those are 
the units).
> ++
Done (though "pixels" would trigger newline, made it (px).

------------
> Labels
> - The "addresses" layer has "Label features" checked, but there are no 
labels. 
> It appears that there is no "label values" set. I'd suggest that untless a 
label 
> values is set, the "label features" be disabled.  And/or some way of making 
it clear to 
> the user that they have to set a "label values" (it's mandatory).
Done

> - On the labels tab the user-entered font size is greyed out on the 
> labels tab. I don't believe it should be (by greying it out it is implying 
> that the user can't edit it). It's not greyed out on the "basic" tab.
GXP

> - 1) Place a label.
> 2) Select geometry - that label.
> 3) Click on "Change feature styles"
> The label becomes a point and all styling is lost and needs to be re-applied.
> == You acknowledged it in your response, but I don't think a fix has been 
implemented as it's still happening.
Fixed
Note: strictly spoken, as in initial issue text, Label Styling for Drawing 
Layer is not required.

------------
> (New issues)
> Printing
> - The colours used in printing seem to be different from the ones used on the 
page. 
> This appears to be an opacity issue (100% opacity they come through 
correctly). 
> Look at the "Address point" layer on-screen and on the print for exmaple.
This is an MFP issue with 3-digit hexcolors, as indicated earlier, see
https://github.com/mapfish/mapfish-print/issues/113. As long as you use 6-digit 
hexcolors for initial
all works as expected. I left the 3-digit colors, e.g. for Adresses, to track 
any future MFP fixes.

> == The print legend is empty when I add it. It should be populated like the 
Heron one.
As expected, see issue 144: MFP does not support Vector Legends unfortunately

> == Labels show up as points in print preview!
Fixed
> == Labels print as points when done through print preview!
> (I suspect these last two relate to that bug you just referenced).
Fixed

Original comment by jus...@gmail.com on 18 Feb 2014 at 5:56

GoogleCodeExporter commented 9 years ago 
Thanks, that's much better. It's the little things that make all the 
difference. :-)

For the GXP things, is it worth reporting them upstream to the GXP project?

Original comment by jonathan...@warwickshire.gov.uk on 19 Feb 2014 at 9:51

GoogleCodeExporter commented 9 years ago 
I have bundled all work on Vector Styling in GXP (which was non-existing 
before) in a single issue for practical reasons: 
https://github.com/boundlessgeo/gxp/issues/216. All commits reference this 
issue so the history of changes can be viewed.

I have contacted GXP/Boundless-folks to interest them for Vector Styling and 
related fixes. No reply yet. GXP is a component for several other Boundless 
products like GeoExplorer and OpenGeo Suite.  So GXP-strategy is I assume tied 
to those products, rather than a self-standing project like Heron.  At the same 
time GXP-components are the most adavnced in webmapping AFAICS. I'll Cc: Bart 
here...

Original comment by jus...@gmail.com on 19 Feb 2014 at 10:16

GoogleCodeExporter commented 9 years ago 
Just, an alternative to getting this into GXP (which would require quite a bit 
of review and is probably not gonna happen without funding) would be to do what 
CampToCamp has done with CGXP:

https://github.com/camptocamp/cgxp

Original comment by bart...@osgis.nl on 19 Feb 2014 at 10:23

GoogleCodeExporter commented 9 years ago 
Well, this looks very similar to what we are doing in Heron:

- making changes to my GitHub-fork of GXP: https://github.com/justb4/gxp, Heron 
could be called "JGXP" ;-)
- directly including/syncing this fork into Heron project Subversion via 
"svn-externals": 
https://code.google.com/p/geoext-viewer/source/browse/trunk/heron/ux/gxp/svn-ext
ernals.txt

This way we assure that Heron always uses a tested/known version of GXP. In the 
mean time any enhancements done in both JGXP and the GXP-master branch are 
mutually synced. 

Working on these high-level JavaScript widgets is very labour-intensive and 
yes, would require (lots of) funding. Ideally I would like to see a merged 
project of GeoExt2, GXP and Heron, combining all Widgets into a single source 
tree. The Heron-config related code is actually quite small and could fit under 
an "apps" section together with e.g. GeoExplorer and the GXP-Viewer. But this 
would be a huge undertaking, mainly needing huge amounts of funding. Maybe a 
Russian Oil Baron pops up who lost interest in an English footballteam ;-)? But 
more realistically something like KickStarter would be good place to raise 
funds: https://www.kickstarter.com.

Original comment by jus...@gmail.com on 19 Feb 2014 at 10:43

GoogleCodeExporter commented 9 years ago 
Hi Bart, Now I realize you did the reply #31 above (thought I was talking to 
Jonathan, hence the ref to UK Soccer)!

But still, I may miss the point of CGXP and what you suggest: C2C includes (a 
revision of) GXP as a GH-submodule. My hope is that my clone/PR strategy will 
also bring code back into GXP, though Just Objects is not C2C :-).

Original comment by jus...@gmail.com on 19 Feb 2014 at 10:49

GoogleCodeExporter commented 9 years ago 
Right, I�m only saying it might take a while for your PR to get merged into 
GXP, so some strategy in between makes sense.

But as you said you use a similar strategy as CGXP already, so that is fine in 
the meantime.

Original comment by bart...@osgis.nl on 19 Feb 2014 at 10:53

GoogleCodeExporter commented 9 years ago 
Done for now. Specific bugs and enhancements will be reported in new issues.

Original comment by jus...@gmail.com on 26 Feb 2014 at 12:10