search

smas1 / geoext-viewer

Automatically exported from code.google.com/p/geoext-viewer
GNU General Public License v3.0
0 stars 0 forks source link

OLeditor - IE8 problem #337

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Using IE8 the oleditor shows a grey line instead of the icon toolbar - see pic.

Original issue reported on code.google.com by wolfram.winter on 17 Feb 2014 at 1:15

Attachments:

GoogleCodeExporter commented 9 years ago 
The solution is:

1.) line 15 of geosilk.css
.olEditorControlEditorPanel > div {
change to:
.olEditorControlEditorPanel div {

2.) line 128 of geosilk.css
.olEditorControlEditorPanel > 
div:not(.olControlSeparatorItemInactive):not(.oleControlDisabled) {
change to:
.olEditorControlEditorPanel 
div:not(.olControlSeparatorItemInactive):not(.oleControlDisabled) {

Best
Wolfram

Original comment by wolfram.winter on 17 Feb 2014 at 1:19

GoogleCodeExporter commented 9 years ago 
Weird. It's working for me (Heron 1.0.0). Well, apart from the width issue that 
I've reported before. See attached.

Original comment by jonathan...@warwickshire.gov.uk on 17 Feb 2014 at 1:22

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi Jonathan, 
I can confirm the width issue for IE8 + the newest firefox version - I've been 
working on a solution for it this afternoon - I think I should implement a 
heron 'default_oleditor.css' file for the different themes - the oleditor 
toolbar should be configurable in a horizontal and vertical way - my first 
approaches today seems to solve the width problem - next: hope to fix the 
browser differences...
Best
Wolfram

Original comment by wolfram.winter on 17 Feb 2014 at 7:56

GoogleCodeExporter commented 9 years ago 
Hi all, I've created a 'default-oleditor.css' and a 'default-oleditor-gray.css' 
file - this files should be located in 'resources/css' - you have two sorts of 
toolbars: a vertical static one and a horizontal dynamic one - please have a 
look at the pics - if you agree I would finish it for the other themes and the 
examples.
Best
Wolfram

Original comment by wolfram.winter on 18 Feb 2014 at 1:56

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi Jonathan - BTW: the 'dynamic horizontal/right' version only works with 
firefox but not with IE8 - the trick for IE8 is, to set a static width: 450 for 
.olEditorControlEditorPanel.
Best
Wolfram

Original comment by wolfram.winter on 18 Feb 2014 at 2:05

GoogleCodeExporter commented 9 years ago 
Hi Wolfram,
Looks excellent. I like the vertical toolbar; is there a dynamic version of it?
Best,
Jonathan

Original comment by jonathan...@warwickshire.gov.uk on 18 Feb 2014 at 2:09

GoogleCodeExporter commented 9 years ago 
Hi Wolfram, Good to see you working on this! Has been a nasty issue for some 
time now. 
Looks like something that should be integrated in the original OL Editor Code?
This is what I do in all cases where the issue is within OLEditor:

- open Heron issue (done, issue 337)
- open OLEditor issue at https://github.com/geops/ole/issues
- make fixes in clone of OLEditor
- integrate in OLEditor via Pull request

Maybe I can do the latter two actions once your fix is stable. This is all a 
little bit more work, but cleaner and remaining in true Open Source spirit: 

- other OLEditor users will benefit
- Heron will be kept in sync with OLEditor master branch

Original comment by jus...@gmail.com on 18 Feb 2014 at 5:11

GoogleCodeExporter commented 9 years ago 
Hi Jonathan - poorly only the static version of the vertical toolbar works for 
firefox AND IE8 in 'all cases' :-(( - I had the same toolbar problem four years 
ago when starting with the OL programming... - seems to be a vice versa problem 
between OL and the browser - ok: I'll try to check for 'non global' dynamic 
setting ->  a last time ;-))

Original comment by wolfram.winter on 18 Feb 2014 at 6:53

GoogleCodeExporter commented 9 years ago 
Hi Just - you are right - I'll do so: 1.) I will keep the global changes in the 
OLEditor css file - 2.) parallel to this I will implement the themes coloring 
based on these global changes. Point 1. will fix the editor, point 2. will 
extend heron.

Original comment by wolfram.winter on 18 Feb 2014 at 6:59

GoogleCodeExporter commented 9 years ago 
Hi Just - I've nearly completed my css work for the oleditor. It seems to work 
for IE8 now (and the newest firefox version). My goal is:
1. only one main file for all css oleditor entries: 'default-oleditor.css'
2. implemet all color theme changes concerning the oleditor in the 
'default-theme-xxx.css' files
At last: where should I integrate / document the css position of the toolbar 
(horizontal left/right, vertical left/right) - it's inside the 
'default-oleditor.css' - but with no great comments?

Original comment by wolfram.winter on 26 Feb 2014 at 12:35

GoogleCodeExporter commented 9 years ago 
As a general rule I would advise to fix as much as possible in OLE like the 
global positioning. I like the vertical toolbar!  Even when not integrated in 
OLE main branch on GitHub, the version distributed with Heron is always my fork 
usually synced to OLE main via GitHub Pull Requests.  I can't tell how much 
changes there are in default-theme-xxx.css.

WHen you think you have a stable situation you may attach the CSS file here and 
I will integrate into GitHub, or you may want to do that yourself, but it may 
take some time before it is integrated in OLE and then gets synced back into my 
OLE clone. There may be other scenarios, via your GitHub clone, but I have to 
dive into GitHub specifics.

We have some old action to clean up all CSS anyway...

Original comment by jus...@gmail.com on 26 Feb 2014 at 12:54

GoogleCodeExporter commented 9 years ago 
Hi, please have a look at rev. 1363 - I've added a few css files - in 
combination you can configure the oledit toolbar by 'index.html definition' - 
see 'index-VR-gray.html' in the editorbasics folder.

Original comment by wolfram.winter on 3 Mar 2014 at 6:09

GoogleCodeExporter commented 9 years ago 
Wolfram, thanks for your contributions: index-VR-gray.html really looks nice!

I am a bit confused though w.r.t. the CSS files:

- are the original issues as above solved in ux-oleditor-main.css? It is 
nowhere included.
- should ux-oleditor-main.css be replacing the OLE original geosilk.css?
- editorbasics/index.html does not seem to be changed - or do you need to 
check-in?

There are some minor errors in ux-oleditor-main.css:
- line  134 :   width: 22x !important; ('x' i.s.o. 'px')
- many button styles show  margin style twice, e.g. lines 332 and 335: margin: 
0 !important; resp margin: 2px !important;

It is no problem for me to replace geosilk.css and even to introduce color 
themes into OLE. We can always propose via GitHub but in the meantime it is 
available transparently via ux/ole in Heron (as it refers to my GitHub OLE).

Original comment by jus...@gmail.com on 4 Mar 2014 at 2:05

GoogleCodeExporter commented 9 years ago 
Hi Just, a bit of explanation: I did not want to change anything of the 
oleditor code - it seems to me impossible to have different toolbar locations + 
color themes + IE8 fixes with only ONE css file. On the other side your #11 
comment! OK - I started with the content of the 'geosilk.css' and ended in a 
version that was able to show ONE toolbar location by commenting / decomenting 
some lines in the css. Not very good! So I split this css file to six css 
files: four config files for the toolbar position - they are the starting point 
of including (ux-oleditor-toolbar-xx.css), one shadow file 
(ux-oleditor-toolbar-shadow.css) for shadowing toolbar and dialog box and one 
main css file (ux-oleditor-main.css). At last I added our four color themes 
(ux-oleditor-theme-xxx.css).

The configuration is done by html configuration - please see code example 
'index-VR-gray.html' in the editorbasics folder!

This approach works without changing anything on the oleditor side. On the 
other side I had issue #251 in my mind  - in the same manor the css files for 
the themes, the uxprintpreview and the default.css must be split off to demerge 
the css dependencies (color, fonts, dialog color and so on). At last these 
single css files can join in one/two/... default-xxx.css files - then the 
customer can integrate one default css or can select individual css 
combinations.

Hmmm - just a thought....

OK - at last: you now can copy the 'ux-oleditor-main.css' file back to the 
'geosilk.css' - then you have to uncomment one toolbar version inside of the 
css code - after this there should be no css errors concerning the oleditor 
design (I hope so ;-) ).

Original comment by wolfram.winter on 4 Mar 2014 at 6:59

GoogleCodeExporter commented 9 years ago 
Also have a look here at issue #340:
http://code.google.com/p/geoext-viewer/issues/detail?id=340#c6

Original comment by wolfram.winter on 4 Mar 2014 at 7:38

GoogleCodeExporter commented 9 years ago

Original comment by jus...@gmail.com on 14 Apr 2014 at 2:55