OLeditor - DrawText.js - missing callback funtion

smas1 / geoext-viewer

Automatically exported from code.google.com/p/geoext-viewer

GNU General Public License v3.0

0 stars 0 forks source link

OLeditor - DrawText.js - missing callback funtion #340

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Using the oleditor within the geoext-viewer: the close button of the text input 
box has - under certain circumstances - no effect - this means: the callback 
function of the box is cut off or broken.

Original issue reported on code.google.com by wolfram.winter on 26 Feb 2014 at 12:24

GoogleCodeExporter commented 9 years ago

I've opened an OLEditor issue at https://github.com/geops/ole/issues. The 
solution is simple and added as an github comment.

Original comment by wolfram.winter on 26 Feb 2014 at 12:27

GoogleCodeExporter commented 9 years ago

I can't reproduce (on Chrome) but sounds like an IE-specific issue?

Ok, is this just a CSS fix? and related to issue 337 ?

Original comment by jus...@gmail.com on 26 Feb 2014 at 12:42

Changed state: Started

GoogleCodeExporter commented 9 years ago

Hi just, no css - no browser secific issue - not related to issue 337: 
the heron oleditor example is running fine - only our app shows no reaction of 
the popup close button. Looking at the oleditor code, I recognized the missing 
callback function for the button - its only ONE line of code that must be 
integrated (I've tested it).

Original comment by wolfram.winter on 26 Feb 2014 at 1:19

GoogleCodeExporter commented 9 years ago

Hi Just - I found the error: poorly it's my own code and NOT the oleditor: I 
started my 'index.html' code (as all c programmers did ;-)) ) with a comment 
block <!-- -->  following the html DOCTYPE definitions. Some browsers DOESN'T 
like this!! They show the display errors like: OLE toolbar over the full width 
of the map, or missing callback function of the close button in the edit text 
box, and so on. ALL problems are gone if I change the order of doctype and 
comment:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
        "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
    <meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
    <!--
      ~ This program is free software: you can redistribute it and/or modify
      -->
....
Please close this issue - Thanks!

Original comment by wolfram.winter on 28 Feb 2014 at 9:55

GoogleCodeExporter commented 9 years ago

Yes, that can make much of a difference, also the "charset" line for 
localisation issues.

Some time ago I changed all the Heron examples to use 
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
        "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">

but my IDE, I now see, automatically prefixes the <!-- .. This program is free 
software:.. --> comment block at start of file. So I need to fix again in some 
examples. Good you found this again.

What I always try to do is check with the W3C HTL/CSS validator:
http://validator.w3.org (though it will not  detect the comment line issue)

Original comment by jus...@gmail.com on 28 Feb 2014 at 11:29

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

At last I found, why I thought that the callback function of the oleditor text 
input isn't active - read this:

http://trac.osgeo.org/openlayers/wiki/FrequentlyAskedQuestions#Whatisthemaximuma
mountoflayersIcanhaveinmyOpenLayersMap

=> max amount of layers: 75

My layer amount is about 180 layers - everything is working ... but the popup 
callback is gone - I now know why!

Original comment by wolfram.winter on 4 Mar 2014 at 7:30