Closed GoogleCodeExporter closed 9 years ago
Yes between r1227 and r1268 quite some code has related to Printing
disappeared. Maybe it is because of some merged issues or a delyed check-in? I
can see this in IntelliJ IDEA when comparing SVN history versions....Do you
have diff/merge tools to quickly restore ( IntelliJ IDEA is awesome at this!)
the original code ?
Original comment by jus...@gmail.com
on 11 Mar 2014 at 3:39
Attachments:
Ok but also the changes are visible via:
https://code.google.com/p/geoext-viewer/source/diff?spec=svn1268&r=1268&format=s
ide&path=/trunk/heron/lib/widgets/ToolbarBuilder.js
Original comment by jus...@gmail.com
on 11 Mar 2014 at 3:45
No, I have no diff/merge tools - OK - I will try to fix it rev by rev, because
we are using rev1267 as a production version - the changes in rev1268 are mixed
between new implementations and purging some existing printing code pieces -
hope I can fix it with little amount on this way.
Original comment by wolfram.winter
on 12 Mar 2014 at 7:11
OK - I think with the (re)changes in ToolbarBuilder.js the issues #171, #189
and #319 should be fixed again. I've tested it against our MapFish servlet from
Dec 2013 when I've done these fixes and the implementation of mapAttribution.
Please have a look at it - then please close this issue.
Original comment by wolfram.winter
on 12 Mar 2014 at 9:02
Issue 355 has been merged into this issue.
Original comment by jonathan...@warwickshire.gov.uk
on 31 Mar 2014 at 3:38
Original comment by jus...@gmail.com
on 14 Apr 2014 at 2:51
Fix works for me.
Original comment by jonathan...@warwickshire.gov.uk
on 14 Apr 2014 at 3:04
Original issue reported on code.google.com by
wolfram.winter
on 11 Mar 2014 at 3:20