smas1 / geoext-viewer

Automatically exported from code.google.com/p/geoext-viewer
GNU General Public License v3.0
0 stars 0 forks source link

Trailing Comma in MapContext #347

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Heron 1.0.1 has a error in MapContext.js. Line 57 has a trailing comma.
This causes the Closure Compiler to fail to compile my projects. :-(

Closure Compiler error:
C:\inetpub\wwwroot\libs\heron-1.0.1\script\Heron.js:154: ERROR - Parse error. 
IE8 (and below) will parse trailing commas in array and object literals 
incorrectly. If you are targeting newer versions of JS, set the appropriate 
language_in option.
var 
formFields=[{tag:'input',type:'hidden',name:'data',value:data},{tag:'input',type
:'hidden',name:'filename',value:options.fileName+options.fileExt},{tag:'input',t
ype:'hidden',name:'mime',value:'text/xml'},{tag:'input',type:'hidden',name:'enco
ding',value:'base64'},{tag:'input',type:'hidden',name:'action',value:'download'}
,];var 
form=Ext.DomHelper.append(document.body,{tag:'form',id:'hr_downloadForm',method:
'post',action:Heron.globals.serviceUrl,children:formFields});document.body.appen
dChild(form);form.submit();},openContext:function(mapPanel,options){var 
self=this;var data=null;try{Ext.destroy(Ext.get('hr_uploadForm'));}

Original issue reported on code.google.com by jonathan...@warwickshire.gov.uk on 12 Mar 2014 at 11:07

GoogleCodeExporter commented 9 years ago
Hoi Rinke, can or have you solved this trivial one?

Original comment by jus...@gmail.com on 18 Mar 2014 at 11:05

GoogleCodeExporter commented 9 years ago
Rev 1402

Thanks for reminding me.
Fixed it now.

Original comment by rinke.he...@gmail.com on 18 Mar 2014 at 11:28

GoogleCodeExporter commented 9 years ago
@jonathan : can you complete the QA step (-->Verified) :-)?

Original comment by jus...@gmail.com on 4 Apr 2014 at 10:35

GoogleCodeExporter commented 9 years ago
Yep, seems to be fixed.

Original comment by jonathan...@warwickshire.gov.uk on 4 Apr 2014 at 11:00