smas1 / geoext-viewer

Automatically exported from code.google.com/p/geoext-viewer
GNU General Public License v3.0
0 stars 0 forks source link

(Regression?) - tooltips not working with 1.0.1 #353

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Tooltips in my project have stopped working. I've confirmed that the project 
works just fine with 1.0.0, but when I point it at the 1.0.1 version of Heron, 
the tooltips stop working.

Heron is making the request and getting a valid response, but it's not 
rendering it. There are no JavaScript errors.
I guess this is a result of the work on the vertical feature response?

My tooltip declaration is simply:

    {type: "tooltips", options: {
        tooltip: "Tooltips",
        getfeatureControl: {
            hover: true,
                drillDown: false,
                maxFeatures: 5
        },
        popupWindow: {
            title: "Information",
            hideonmove: false,
            anchored: false,
            featureInfoPanel: {
                displayPanels: ['Grid']
            }
        }
    }},

I can't see the live example to see if the issue is there as it's broken in a 
different way (see other ticket).

Original issue reported on code.google.com by jonathan...@warwickshire.gov.uk on 28 Mar 2014 at 2:06

GoogleCodeExporter commented 9 years ago
There were quite some changes in 1.0.1 for featurepanel. I think displayPanels: 
['Grid'] has been split into two config values 'Table' and 'Detail'. Made small 
fix to replace 'Grid' with 'Table' as to not break existing configs. 'Tree' and 
'XML' are not supported anymore.

So in your case: you best replace 'Grid' with 'Table'.

Original comment by jus...@gmail.com on 28 Mar 2014 at 2:45

GoogleCodeExporter commented 9 years ago
Hi Just,
Good catch, that fixed it.

For backwards compatibility I'd suggest:
a) Advertising this in release notes.
b) Allowing "Grid" to work but be deprecated.

Original comment by jonathan...@warwickshire.gov.uk on 28 Mar 2014 at 3:08

GoogleCodeExporter commented 9 years ago
Yes, "deprecated" was the word I was looking for ;-), been away too long from 
the Java-world where "deprecated"  is the number one word...

Original comment by jus...@gmail.com on 28 Mar 2014 at 3:13