smas1 / geoext-viewer

Automatically exported from code.google.com/p/geoext-viewer
GNU General Public License v3.0
0 stars 0 forks source link

Show Load Mask for HeronMapContext optional #391

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When a HeronMapContext is being loaded a pink screen with a loading message is 
shown. In some cases this is not desirable. 

In the configuration there should be an extra option to show or ignore the 
loading message.

The default would be showing the load mask.

Original issue reported on code.google.com by Martijn....@gmail.com on 4 Jul 2014 at 7:18

GoogleCodeExporter commented 9 years ago

Original comment by Martijn....@gmail.com on 4 Jul 2014 at 11:38

GoogleCodeExporter commented 9 years ago
Martijn, during verification I found that "unmerged" context loading does not 
work anymore in the latest svn version. This can be reproduced by going to 
http://lib.heron-mc.org/heron/latest/examples/heronmapcontext and pressing (?) 
help button and selecting the "unmerged" example. In this case, dubbed 
"unmerged", there is a main context file that includes and loads other contexts 
(synchronously) while loading. Something has changed, I think in the sync/async 
mechanism. "unmerged" loading worked in the original v1.0.2:

See

http://lib.heron-mc.org/heron/latest/examples/heronmapcontext/index.html?context
=context/pdok-thematic-unmerged.xml 

vs the original

http://lib.heron-mc.org/heron/1.0.2/examples/heronmapcontext/index.html?context=
context/pdok-thematic-unmerged.xml

Original comment by jus...@gmail.com on 4 Jul 2014 at 12:52

GoogleCodeExporter commented 9 years ago
Ok, the problem was that this.async was changed to this.options.async and that 
subloading of included contexts always use synchronous loading. This value was 
not picked up. Also the setOptions() is not required, as this is exactly what 
the function Ext.apply(this, config.options) will do. So the options are now 
also directly class-instance vars. This also makes them better documentable.

So all in all the issue is now Ready again.  You may want to verify.

Original comment by jus...@gmail.com on 4 Jul 2014 at 1:23

GoogleCodeExporter commented 9 years ago
Ok now, also 'async' is no longer a config option as it made no sense anyway 
(plus sync loading did not work at toplevel...).

Original comment by jus...@gmail.com on 4 Jul 2014 at 2:26