search

smash-transport / smash-analysis

Analysis tools that are useful to calculate observables from SMASH.
http://theory.gsi.de/~smash/analysis_suite/current/
Other
8 stars 2 forks source link

Comment about maximum impact parameter #68

Closed RenHirayama closed 2 years ago

RenHirayama commented 2 years ago

Changing it breaks the analysis, since bmax is set explicitly in geometrical_cross_section.py. It would be nice to fix this in the future, perhaps taking the value from the config file.

NGoetz commented 2 years ago

Is it possible to include an automatic check in geometrical_cross_section.py? How much effort is it to just take the value from the config file?

gabriele-inghirami commented 2 years ago

How much effort is it to just take the value from the config file?

If the relative path of the file with respect to the script does not change, I would say that it's a low effort. Being just one value, I would not even use YAML, but just parse the lines of the config file and extract the second entry of the row if the first one is Max:.

RenHirayama commented 2 years ago

If the relative path of the file with respect to the script does not change, I would say that it's a low effort.

I think it's always the config file in the test/cross_sections/config.yaml

Is it possible to include an automatic check in geometrical_cross_section.py? How much effort is it to just take the value from the config file?

I also think it's not very hard, but in the meantime it's useful to have at least a warning for the user.