smashgg / developer-portal

A place for developers interested in smash.gg's API
MIT License
47 stars 42 forks source link

Option filter 'playerIds' in SetFilters does new requests #196

Open d0ud3 opened 1 year ago

d0ud3 commented 1 year ago

Option filter 'playerIds' in SetFilters does new requests

Hello, when I request Sets of a Player and I use the playerIds filter option to filter on Sets of this Player and the specified playersIds Then the API returns Sets of this Player OR Sets of the playersIds.

I query the API from a Player, and I access Sets of THIS Player without filter option. So if I use playersIds filter option it should just filter on sets of THIS Player AND sets of playersIds. But here this filter option adds additional Sets which are not part of the Player root.

I think, "Thinking in Graphs" its not respected here ?

It is possible that you are using the same resolver for Sets and for Sets of a Player with filters

They should be different ?

Maybe I didn't understand well how these filters work and GraphQl too. I am waiting for your return so that you can give me your point of view.

I have attached an example of the queries I used.

In the response I just want sets of "gamerTag": "doude" VS "gamerTag": "Kinato"

Variables are at the end of files

Query getPlayerSets : query_getPlayerSets.txt

Query getPlayerVsPlayerSets : query_getPlayerVsPlayerSets.txt