search

smashingboxes / box_cutter

Box Cutter is inspired by thoughtbot's Suspenders. Just like Suspenders says, use Box Cutter if you're in a rush to build something amazing; don't use it if you like missing deadlines.
MIT License
4 stars 2 forks source link

Adds Travis and CodeClimate #1

Open leonelgalan opened 10 years ago

leonelgalan commented 10 years ago
leonelgalan commented 9 years ago

@ethikz, comment something about the need of SCSS and JS lints on the default Travis configuration.

ethikz commented 9 years ago

There needs to be SCSS and JS Linting done in the default configuration of Travis. Currently I have SCSS lint working:

.travis.yml

before_script:
  - gem install scss-lint
script:
  - scss-lint --config=.scss-lint.yml

This should include an scss-lint config file based off our style guide which we have outlined in the wiki.

It would have the following configuration similar to below:

.scss-lint.yml

scss_files:
  - 'app/assets/stylesheets/**/*.css.scss'

exclude:
  - 'app/vendor/assets/stylesheets/**'

linters:
  StringQuotes:
    style: single_quotes
  Indentation:
    width: 2
  LeadingZero:
    enabled: true
  SelectorDepth:
    enabled: true
  SelectorFormat:
    # Used for BEM syntax
    convention: '^[a-z]([-]?[a-z0-9]+)*(__[a-z0-9]([-]?[a-z0-9]+)*)?((_[a-z0-9]([-]?[a-z0-9]+)*){2})?$'
  CapitalizationInSelector:
    enabled: true
  NameFormat:
    enabled: false
  PropertySortOrder:
    enabled: true
  SingleLinePerSelector:
    enabled: true
  DeclarationOrder:
    enabled: true
  IdWithExtraneousSelector:
    enabled: false
  PlaceholderInExtend:
    # Used for clearfix extending
    enabled: false
BrandonMathis commented 9 years ago

@ethikz should commit that code to the pr

:gun: :fire:

:smoking: :sunglasses:

ethikz commented 9 years ago

I will soon, maybe later this week. I'll create a new branch

BrandonMathis commented 9 years ago

No need to create a new branch. Just commit directly to this one

ethikz commented 9 years ago

Ok I'll commit it but not sure where it's supposed to go?

BrandonMathis commented 9 years ago

Okay, so this commit is regarding adding travis and Codeclimate to the GEM and not the generated apps. We need to create a seperate card for what @ethikz is requesting but I don't think this project has a trello board.