search

smashingboxes / boxcar-generator-archive

A tool for generating Rails applications with the best practices of the Smashing Boxes team.
MIT License
16 stars 2 forks source link

Non-API builds are still getting SmashingDocs config. #112

Open woolsox opened 6 years ago

woolsox commented 6 years ago

When spinning up a new app - we get the Is this an API only app? (y/N) prompt. In the case of answering N we still end up with spec_helper.rb config which has SmashingDoc references in it:

config.after(:each, type: :controller) do SmashingDocs.run!(request, response, true) end

This will cause rspec to throw a error: NameError: uninitialized constant SmashingDocs

dkniffin commented 6 years ago

@TylerRockwell Is this expected? I can't remember if SmashingDocs is useful against rails-view apps or not.

TylerRockwell commented 6 years ago

@dkniffin It looks like SmashingDocs isn't being installed, for any type of app. Some of the config is added via this line, but I don't see the gem getting added anywhere.

And no, I don't think SmashingDocs is useful for a full stack app. Not unless it also has some API endpoints.