Rewrite rubocop config to remove defaults

[dkniffin]

Why?

• A lot of our rubocop settings were the same as the default, which caused issues when rubocop decided to rename cops.
• Also, it was difficult to tell whether a rubocop config was overriding the default or not
• As stated in #102, there were some cops we wanted to disable

What Changed?

• Remove any cops that matched the defaults
• Review all existing configs and make changes as necessary (changes have been discussed in the #rubocop-cleanup Slack room)

[dkniffin]

TODO: figure out if we want to use Style/PercentLiteralDelimiters or not

[dkniffin]

Thanks, @TylerRockwell!

[dacur]

yvw

On Fri, Sep 28, 2018 at 2:55 PM Derek Kniffin notifications@github.com wrote:

Thanks, @TylerRockwell https://github.com/TylerRockwell!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/smashingboxes/boxcar/pull/118#issuecomment-425533069, or mute the thread https://github.com/notifications/unsubscribe-auth/AEDa_hmizqERI21H3wUOhcwzdhTbG8oAks5ufnCIgaJpZM4W9wV9 .

--

[image: Smashing Boxes] http://smashingboxes.com/

David Curtis Software Engineer Smashing Boxes

p. 919-627-7770 e. david.curtis@smashingboxes.com w. smashingboxes.com