search

smashingboxes / boxcar-generator-archive

A tool for generating Rails applications with the best practices of the Smashing Boxes team.
MIT License
16 stars 2 forks source link

Force ssl on production #142

Closed eddwk closed 5 years ago

eddwk commented 5 years ago

Why?

https://github.com/smashingboxes/boxcar/issues/124

dacur commented 5 years ago

very nice

On Mon, Nov 19, 2018 at 12:56 PM Edd Kerr notifications@github.com wrote:

@eddwk commented on this pull request.

In spec/support/shared_examples/configure_prod_environment.rb https://github.com/smashingboxes/boxcar/pull/142#discussion_r234721058:

@@ -0,0 +1,7 @@ +# frozen_string_literal: true + +shared_examples_for "a run that configures the prod environment" do

  • it "forces ssl configuration" do
  • expect(production_config).to match(/^\s+config.force_ssl = true/)

I commented out the code in app builder to make sure and it does indeed fail if you do that so its gtg. I believe that match method checks that the entire line matches the pattern, not just a portion of it. so in order for the default config to pass it would be expect(production_config).to match(/^\s+# config.force_ssl = true/)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/smashingboxes/boxcar/pull/142#discussion_r234721058, or mute the thread https://github.com/notifications/unsubscribe-auth/AEDa_n4uOfJJj-KK7CR42SuJiu0hIfV2ks5uwvDLgaJpZM4YpjMN .

--

[image: Smashing Boxes] http://smashingboxes.com/

David Curtis Software Engineer Smashing Boxes

p. 919-627-7770 e. david.curtis@smashingboxes.com w. smashingboxes.com