search

smashingboxes / cardboard-admin-archive

Rails 4 CMS
http://smashingboxes.com
Other
65 stars 13 forks source link

Fix for #100 #108

Closed iandonovan closed 9 years ago

iandonovan commented 9 years ago

Open links from CB to the outside world in a new tab.

How do I test this? I'm thinking integration, nice as it would be to just test the helper.

joeyjoejoejr commented 9 years ago

Just a couple of issues here.

iandonovan commented 9 years ago

Once @greg5green confirms/denies my point re: #host, I'll either fix it again or merge it. :-)

iandonovan commented 9 years ago

@joeyjoejoejr I think this is good to go, Big Dawg.

joeyjoejoejr commented 9 years ago

This was pulled into the rails 4 branch. Is that correct @ian-donovan ?

iandonovan commented 9 years ago

@joeyjoejoejr Yeah, that's right. Someone (I think it was a consensus of the BE team, actually) said to put new Cardboard work on top of the 4.2 branch. Soooooo I did.