Replaces minitest with Rspec

smashingboxes / cardboard-admin-archive

Rails 4 CMS

http://smashingboxes.com

Other

65 stars 13 forks source link

Closed leonelgalan closed 9 years ago

leonelgalan commented 9 years ago

We, collectively decided (locally with no opposition in #99) that the RSpec ecosystem was a better option.

Replaces minitest with Rspec.
Fixes #42 (seed file running twice), I did it in this branch, since the solution depends on the dummy App.

iandonovan commented 9 years ago

Nothing leaps out at me as wrong or bad, and the tests passing means things have changed over correctly. +1.

joshvc commented 9 years ago

Looks good to me, too. Nice work, @leonelgalan.

elfassy commented 9 years ago

@leonelgalan I'm not sure i agree with moving the rake task into the dummy test folder. spec/dummy/lib/tasks/cardboard.rake

The rake might be used in the tests but it's also used by the main app. We can move it to the lib folder. Thoughts?

EDIT: just saw the blog link. We can move it out of the rake folder but also keep it out of the spec/dummy folder. I think that should work

leonelgalan commented 9 years ago

I don't like it either, but it solves the duplicate run issue. There might be a setup where it still lives under lib/ but doesn't cause the duplicate, but that will have to be an improvement. The task is added into the engine rake_tasks, so it's available to the apps using this gem (https://github.com/smashingboxes/cardboard/commit/416dc972304ff28084b46a2dfbc94f9e00c2a5f9#diff-00f7b4514e6dcb073408ccf0314bcc9eR72)

elfassy commented 9 years ago

Agreed. Lets put that on the todo list. No one in a couple of months will think that we put core functionality in the dummy test app.