smashub / choco

ChoCo: the Chord Corpus
Other
58 stars 6 forks source link

Wrong minor key annotation in Wikifonia #71

Closed andreamust closed 2 years ago

andreamust commented 2 years ago

Many minor key annotations within the Wikifonia dataset are wrong. More specifically, some minor key annotations are annotated as: - major instead of - or minor.

For example, in the file wikifonia_145.jams the key is: A- major, when the context clearly shows it to be A- or A minor.

The same thing happens for example in the file wikifonia_223.jams.

jonnybluesman commented 2 years ago

Checking now, but there might be some misalignment in our files. The file of wikifonia_145 is "Ray Davies - Sunny Afternoon.mxl" which seems to be in F:major from the only KeySignature in music_21 (and not A- minor?).

andreamust commented 2 years ago

I have checked and probably there was a misalignment with some files since I reported the isse by looking at the validation branch before it was aligned with the main branch.

However, I managed to find some errors in the updated files as well:

jonnybluesman commented 2 years ago

We confirmed that - and m denote "flat" and "minor" in music_21, respectively. Conventions correctly handled by the converter. No need to re-generate the partition for now.