search

smashwilson / merge-conflicts

Resolve git merge conflicts in Atom
https://atom.io/packages/merge-conflicts
MIT License
431 stars 42 forks source link

Function.extractParams is deprecated. #254

Closed mikemcbride closed 7 years ago

mikemcbride commented 7 years ago

Assigning custom properties to a marker when creating/copying it is deprecated. Please consider storing the custom properties you need in some other object in your package, keyed by the marker's id property.

Function.extractParams (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker.js:43:14)
MarkerLayer.markRange (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71)
DisplayMarkerLayer.markBufferRange (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62)
TextEditor.markBufferRange (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/text-editor.js:1753:38)
ConflictVisitor.markSide (/Users/mcbridem/.atom/packages/merge-conflicts/lib/conflict.js:308:38)
ConflictVisitor.visitOurSide (/Users/mcbridem/.atom/packages/merge-conflicts/lib/conflict.js:264:27)
pk-pranshu commented 7 years ago

Assigning custom properties to a marker when creating/copying it is deprecated.
Please, consider storing the custom properties you need in some other object in your package, keyed by the marker's id property. 


MarkerLayer.markRange - /Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71
DisplayMarkerLayer.markBufferRange - /Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62
TextEditor.markBufferRange - /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:1753:38
ConflictVisitor.markSide - /Users/prkumar/.atom/packages/merge-conflicts/lib/conflict.js:308:38
ConflictVisitor.visitOurSide - /Users/prkumar/.atom/packages/merge-conflicts/lib/conflict.js:264:27```
WaKeMaTTa commented 7 years ago

Assigning custom properties to a marker when creating/copying it is deprecated. Please, consider storing the custom properties you need in some other object in your package, keyed by the marker's id property.

Function.extractParams - /opt/atom/resources/app.asar/node_modules/text-buffer/lib/marker.js:43:14
MarkerLayer.markRange - /opt/atom/resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71
DisplayMarkerLayer.markBufferRange - /opt/atom/resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62
TextEditor.markBufferRange - /opt/atom/resources/app.asar/src/text-editor.js:1753:38
ConflictVisitor.markSide - /home/wakematta/.atom/packages/merge-conflicts/lib/conflict.js:308:38
ConflictVisitor.visitTheirSide - /home/wakematta/.atom/packages/merge-conflicts/lib/conflict.js:301:29

Specs:

ryanpatiency commented 7 years ago

same here

smashwilson commented 7 years ago

Duplicate of #262.