search

smashwilson / merge-conflicts

Resolve git merge conflicts in Atom
https://atom.io/packages/merge-conflicts
MIT License
432 stars 42 forks source link

Function.extractParams is deprecated. #262

Open coolamit1240 opened 7 years ago

coolamit1240 commented 7 years ago

Assigning custom properties to a marker when creating/copying it is deprecated. Please, consider storing the custom properties you need in some other object in your package, keyed by the marker's id property.

Function.extractParams (/opt/atom/resources/app.asar/node_modules/text-buffer/lib/marker.js:43:14)
MarkerLayer.markRange (/opt/atom/resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71)
DisplayMarkerLayer.markBufferRange (/opt/atom/resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62)
TextEditor.markBufferRange (/opt/atom/resources/app.asar/src/text-editor.js:1753:38)
ConflictVisitor.markSide (/home/amit/.atom/packages/merge-conflicts/lib/conflict.js:308:38)
ConflictVisitor.visitTheirSide (/home/amit/.atom/packages/merge-conflicts/lib/conflict.js:301:29)
bhushangahire commented 7 years ago

+1

ItamarGronich commented 7 years ago

Me two +1

danfoley commented 7 years ago

+1

jasondibenedetto commented 7 years ago

+1

amoghesturi commented 7 years ago

+1

fh250250 commented 7 years ago

+1

g0ody commented 7 years ago

+1

jurmarcus commented 7 years ago

+1

deemco commented 7 years ago

+1

patrickml commented 7 years ago

+1

ibcWillJust42 commented 7 years ago

+1

Andor-Z commented 7 years ago

+1

criswilk commented 7 years ago

+1

erasmus commented 7 years ago

+1

timfallmk commented 7 years ago

+1

enygmatik commented 7 years ago

+1

HermanBergner commented 7 years ago

+1

Nrohtgnohp commented 7 years ago

+1

shillem commented 7 years ago

+1

iknowmac commented 7 years ago

+1

pichouk commented 7 years ago

Instead of just adding "+1" (did you know you can just thumbsup the first message ?) until the end of time, does anyone understand the issue/have an idea of how to fix this ?

timfallmk commented 7 years ago

@pichouk I think the suggested solution was in the first message of this issue. I just don't see any movement on this repo.

smashwilson commented 7 years ago

This was actually fixed in smashwilson/merge-conflicts#265, I just, uh, never actually did the release. 😅 I just pushed 1.4.5 with that PR merged, but completely untested because, as some of you have noticed:

I just don't see any movement on this repo.

:sparkles: This repository is being deprecated :sparkles:

The full announcement is there, but the short version is that there's a better core package now that eclipses the functionality in this one :grin: