search

smashwilson / slack-emojinator

Bulk upload emoji into Slack
MIT License
328 stars 52 forks source link

export.py relies on idna-ssl, but it's not declared in the pipenv file #37

Closed chief-tyrol closed 4 years ago

chief-tyrol commented 4 years ago

Noticed this while I was working on https://github.com/smashwilson/slack-emojinator/pull/36 (prior to my changes :smile:), but didn't get around to documenting it previously.

Minimal example showing the issue

Fails

git clone git@github.com:smashwilson/slack-emojinator.git
cd slack-emojinator/
docker run --rm -w=/workdir -v "$(pwd)":/workdir python:3.6 sh -c 'pip install pipenv; pipenv install; pipenv run python export.py --help'
Traceback (most recent call last):
  File "export.py", line 6, in <module>
    import aiohttp
  File "/root/.local/share/virtualenvs/workdir-tL8tMG2Q/lib/python3.6/site-packages/aiohttp/__init__.py", line 6, in <module>
    from .client import BaseConnector as BaseConnector
  File "/root/.local/share/virtualenvs/workdir-tL8tMG2Q/lib/python3.6/site-packages/aiohttp/client.py", line 32, in <module>
    from . import hdrs, http, payload
  File "/root/.local/share/virtualenvs/workdir-tL8tMG2Q/lib/python3.6/site-packages/aiohttp/http.py", line 7, in <module>
    from .http_parser import HeadersParser as HeadersParser
  File "/root/.local/share/virtualenvs/workdir-tL8tMG2Q/lib/python3.6/site-packages/aiohttp/http_parser.py", line 15, in <module>
    from .helpers import NO_EXTENSIONS, BaseTimerContext
  File "/root/.local/share/virtualenvs/workdir-tL8tMG2Q/lib/python3.6/site-packages/aiohttp/helpers.py", line 59, in <module>
    import idna_ssl
ModuleNotFoundError: No module named 'idna_ssl'

Succeeds

git clone git@github.com:smashwilson/slack-emojinator.git
cd slack-emojinator/
docker run --rm -w=/workdir -v "$(pwd)":/workdir python:3.6 sh -c 'pip install pipenv; pipenv install; pipenv install idna-ssl; pipenv run python export.py --help'