search

smazzanti / mrmr

mRMR (minimum-Redundancy-Maximum-Relevance) for automatic feature selection at scale.
MIT License
531 stars 79 forks source link

Move `polars` to list of required packages #46

Closed svengiegerich closed 1 week ago

svengiegerich commented 6 months ago

Based on my user experience, polars seem to be as it is an required and not just an optional package.

I base this on the following error message,

  File "/home/conda/staged-recipes/build_artifacts/mrmr-selection_1715720114089/test_tmp/run_test.py", line 2, in <module>
    import mrmr
  File "/home/conda/staged-recipes/build_artifacts/mrmr-selection_1715720114089/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.12/site-packages/mrmr/__init__.py", line 3, in <module>
    from . import polars
  File "/home/conda/staged-recipes/build_artifacts/mrmr-selection_1715720114089/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.12/site-packages/mrmr/polars.py", line 3, in <module>
    import polars as pl
ModuleNotFoundError: No module named 'polars'

which I ran into here, trying to specify all necessary requirements for adding the package to conda.

enryH commented 5 months ago

this is now already present on the main branch (https://github.com/smazzanti/mrmr/commit/dc0fa97d41f5edbb53576cc42445786aef01c27d), but not yet release on pypi. Could this be done soon?