search

smbache / ensurer

Ensure values are as expected at runtime
Other
84 stars 4 forks source link

Code formatting wrong (?) #3

Closed gaborcsardi closed 10 years ago

gaborcsardi commented 10 years ago

See e.g. https://github.com/smbache/ensurer/blob/master/R/ensures_that.R#L106 Is this as intended? It falls apart in my editor as well....

smbache commented 10 years ago

This is of course not intended.

You mean you don't use Rstudio?? :-O

;-)

gaborcsardi commented 10 years ago

I actually wanted to submit some simple pull requests, but it is kind of a pain to edit the code and keep the formatting. :( After 15 years of Emacs, Rstudio is kind of painful, too.

Anyway, what do you want to do? I hate commits that just format the code, they mess up the history. Do you want to fix this? In a single commit? Or can I just submit a PR and fix (some of) it at the same time (not the best, imho)? Or submit a PR and keep the current formatting?

smbache commented 10 years ago

Ahh, no worries, I'll fix it up soon :)

gaborcsardi commented 10 years ago

One solution to this is http://editorconfig.org/ Of course RStudio would need to support it....

smbache commented 10 years ago

All good now? :)

gaborcsardi commented 10 years ago

Looks much better, thanks.

smbache commented 10 years ago

I'm the one thanking... :)