search

smcameron / open-simplex-noise-in-c

Port of Kurt Spencer's java implementation of open simplex noise to C -- Note: This is NOT Ken Perlin's Simplex noise algorithm.
The Unlicense
139 stars 19 forks source link

Use unsigned integer for seed calculations to avoid undefined overflow #11

Closed jeffkdev closed 4 years ago

jeffkdev commented 4 years ago

Closes #10

smcameron commented 4 years ago

Committed as 0fef0dbedd76f767da7e3c894822729d0f07e54d

smcameron commented 4 years ago

You might want to send this patch to the godot people as well, as they have a copy of this code in their repo here: https://github.com/godotengine/godot/blob/master/thirdparty/misc/open-simplex-noise.c

jeffkdev commented 4 years ago

Looks like they have an open issue for it. I left a comment here: https://github.com/godotengine/godot/issues/31291

On Tue, Jan 28, 2020 at 8:54 PM smcameron notifications@github.com wrote:

You might want to send this patch to the godot people as well, as they have a copy of this code in their repo here: https://github.com/godotengine/godot/blob/master/thirdparty/misc/open-simplex-noise.c

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/smcameron/open-simplex-noise-in-c/pull/11?email_source=notifications&email_token=AEKVTOZNP5LK72CAOF7WCHTRADVUZA5CNFSM4KM5E6V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKFYNEQ#issuecomment-579569298, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEKVTO4JEYMMLT4C4ICL5L3RADVUZANCNFSM4KM5E6VQ .