[royal-wedding] cargo is not emptied when it should

[MCMic]

In the bad ending of royal wedding mission, the cargo was not empied.

I received the payment, which means check_player_cargo did return true, but collect_player_cargo somehow failed because the manifest still showed the mission cargo after mission end.

[smcameron]

Ok, I think this commit should fix it:

• decf388536ce384f24f2fb4e66bc41687ccfe7ab Allow Lua scripts to set cargo bays empty by setting commodity index …

A couple other related commits:

• cab83e8689c3a34eaf58cc5336b9b4a1bc2885bb Add Lua test script for adding and removing player cargo bay entries
• 17454b89da37013b21f88c534ac733662976491d Ensure royal wedding mission does not create multiple wedding-cake or…

[MCMic]

We played the mission and it crashed after docking at sb-29. We tried again and same crash. Most likely when the prince is supposed to come aboard.

I tested it a few days ago and it worked, so I think it is related to those fixes.

[smcameron]

What crashes? snis_server? or just the Lua script?

Anything in snis_server_log.txt?

[MCMic]

snis_server crashes. I think snis_server.default.log was overwritten because we relaunched it. I had to delete the lock file by hand to do so.

[MCMic]

Hum, I tried editing the script to trigger the board_prince function at start and nothing crashes. I will have to do the mission again to see if I can reproduce the crash or if it was specific to something in our setup.

[MCMic]

I cannot reproduce the crash on a single computer.

Things that might play a role:

1. We had 6 clients with the 6 stations
2. The sound server was not the main screen/server but one of the clients (engeneering I think)
3. I cannot remember the TTS situation, not all stations had it I guess
4. We took some time to reach the starbase, but the second time not that much and it still crashed.
5. The Comms station had a faulty ethernet cable and was sometimes offline.

[smcameron]

Ok, thanks.