search

smcameron / space-nerds-in-space

Multi-player spaceship bridge simulator game. Captain your starship through adventures with your friends. See https://smcameron.github.io/space-nerds-in-space
GNU General Public License v2.0
724 stars 73 forks source link

snis_client --monitor option has been broken since the SDL2 conversion #335

Open smcameron opened 1 year ago

smcameron commented 1 year ago

Original commit to support multiple monitors via GTK stuff is here: c31d82b8a280b0fac4a0c87b45ddee2bd5fdc912

We still have the code to process the option, but it doesn't do anything but set monitorid, which is never used. (Surprised clang scan-build didn't mark this as a dead store... maybe it did, but I don't remember seeing it.)

$ grep monitorid snis_client.c
static int monitorid = -1;
                monitorid = value;

Some possibly relevant info re multiple monitors and SDL2: https://stackoverflow.com/questions/18728821/multiple-displays-in-sdl2