search

smcameron / space-nerds-in-space

Multi-player spaceship bridge simulator game. Captain your starship through adventures with your friends. See https://smcameron.github.io/space-nerds-in-space
GNU General Public License v2.0
729 stars 73 forks source link

SNIS_Commander is a web interface to send commands #358

Closed spaceshipoperator closed 6 months ago

spaceshipoperator commented 6 months ago

no changes to existing files, just added a very minimal .ipynb

in a python virtualenv with viola available you can:

 voila --debug --Voila.ip=0.0.0.0 --port 9996 ./SNIS_Commander.ipynb

which will serve a very rudimentary web application with a simple form which sends commands to "ship" (natural-language-fifo), "game" (demon mode) and messages which will be read by the computer (text-to-speech)

Signed-off-by: bmuckian@gmail.com

smcameron commented 6 months ago

Hi, and thanks!

I'm not familiar with voila, and only sorta familiar with python. Also, there's a few different commits in this pull request, but I suspect you only mean to include the one that adds the SNIS_Commander.ipynb file, is that correct?

So, my inclination for this kind of add-on is to create a "Contrib" subdirectory, and put SNIS_Commander.ipynb in there, maybe in it's own subdirectory of Contrib, with a README that is basically your pull request description. How does that sound?

smcameron commented 6 months ago

After thinking a bit more, I went ahead and committed your change in Contrib, on the theory that it can always be changed later if that is not satisfactory for whatever reason.

spaceshipoperator commented 6 months ago

very cool (and thank you for patience/tolerance for my sloppy PR); I very much like Contrib; I will consider more possibilities there; the "SNIS Commander" is definitely something I will use: pull it up on my phone while playing on N workstations; to do stuff like pause the game, which I only just discovered about a week ago, or tell the ship to go somewhere, do something...I think super useful, hopefully others will too; thank you again 🙏

smcameron commented 6 months ago

You're welcome, and thanks for the contribution!