search

smcantab / sens

Highly modular, parallel implementation of Superposition Enhanced Nested Sampling
5 stars 1 forks source link

in SASampler: copy_minima and centre_minima keywords seem redundant to me, I shall remove copy_minima. Also need to pass more keywords to the simple NestedSamplingSA, since SASampler has been modified #5

Closed smcantab closed 11 years ago

js850 commented 11 years ago

copy_minima and centre_minima are not redundant. you can copy minima without centering them.

smcantab commented 11 years ago

ok I just figured that there are two samplers defined, one is HSASampler and the other one is SASampler, I had not refreshed eclipse after the last pull.

On Tue, Sep 24, 2013 at 2:13 PM, Jacob Stevenson notifications@github.comwrote:

copy_minima and centre_minima are not redundant. you can copy minima without centering them.

— Reply to this email directly or view it on GitHubhttps://github.com/smcantab/sens/issues/5#issuecomment-25001453 .

smcantab commented 11 years ago

ok I see what's going on now, i'm closing the issue.