search

smcgivern / cricket-query

MIT License
0 stars 0 forks source link

Annoyance: inconsistent team names #3

Closed smcgivern closed 1 year ago

smcgivern commented 2 years ago

https://sean.mcgivern.me.uk/cricket-query/help/#inconsistent-team-names

The team name columns (team and opposition) are internally consistent - they always have the same values for the same teams - but they are inconsistent globally. For instance, we have 'Pakistan' (men), 'PAK Women', 'Australia' (men), 'AUS Women', but then 'India' (men) and 'India Women'.

Should be an easy fix in https://github.com/obrasier/cricketstats. If doing a full re-scrape, I should do this at the same time as #1 and #2. It should also be possible to just rewrite the existing data files directly.

As we have a table per gender, format pair anyway, there's no problem in just calling both the men's and women's teams 'Australia'. It's not like we call them 'Australia Test', 'Australia ODI', and 'Australia T20I'!

smcgivern commented 2 years ago

I have only just realised that this is probably to match Cricinfo. https://stats.espncricinfo.com/ci/engine/stats/index.html?class=10;filter=advanced;orderby=start;page=1;size=200;template=results;type=team;view=innings has all of these women's team name examples. I don't understand why, though.

It might be nicer to create a mapping of all of these weird and wonderful Cricinfo names to sensible ones?