search

smclab / titaniumifier

Get a Titanium™ SDK CommonJS module out of a Node package!
GNU Lesser General Public License v2.1
95 stars 15 forks source link

The generated package.json has a "main" script that doesn't exist #34

Closed FokkeZB closed 9 years ago

FokkeZB commented 9 years ago

Reading https://github.com/FokkeZB/ti-html2as/issues/14 I saw that indeed https://github.com/FokkeZB/ti-html2as/blob/master/example/modules/commonjs/nl.fokkezb.html2as/1.2.0/package.json has index.js for main while that should be nl.fokkezb.html2as.js.

yuchi commented 9 years ago

It shouldn’t be read at all :confused:

does that mean than on mobileweb the app reads package.json files?

FokkeZB commented 9 years ago

I guess, or at least assumes index.js. It would be an easy fix I guess to just set main to the actual "main" script ;)

yuchi commented 9 years ago

Yeah and it should the the right thing to do since the resulting zip can be considered as an actual package where the main is not the old one anymore.

yuchi commented 9 years ago

I’ll solve in hours.

FokkeZB commented 9 years ago

How may of those? :stuck_out_tongue:

yuchi commented 9 years ago

A lot of them!

yuchi commented 9 years ago

Version 1.4.0 is out and should have fixed this issue.

You need to rebuild the module.

(Sorry for the wait)

FokkeZB commented 9 years ago

Thx!