search

smcllns / css-social-buttons

Zocial: CSS login and social buttons
MIT License
1.68k stars 292 forks source link

updated instagram icon #81

Closed crowmagnumb closed 9 years ago

crowmagnumb commented 9 years ago

Updated the instagram icon to be more modern

zimbatm commented 9 years ago

Thanks. For the curious,

before: screen shot 2015-06-23 at 20 39 05

after: screen shot 2015-06-23 at 20 39 19

crowmagnumb commented 9 years ago

Cheers! Looks good.

crowmagnumb commented 9 years ago

On that note, it looks a tiny bit small to me. Is this somehow due to the svg image I uploaded or is something else controlling that? How can that be adjusted?

zimbatm commented 9 years ago

You're right, the svg is smaller than it's viewport.

If you open the file in a svg editor you will see that and adjust it. I would do it but my Inkscape is broken at the moment.

Another way to see the problem is to create an test.html file that contains the following:

<img src="src/instagram.svg" border=1>

If you open this with your browser you will see the space between the icon and the 1 pixel border.

zimbatm commented 9 years ago

Here is another view of the issue: https://samcollins.github.io/css-social-buttons/src/

crowmagnumb commented 9 years ago

The size issue is another thing altogether but really shouldn't matter since they are svg's and scale down well. I'm not sure how to scale the image down. Anyway, I have made a new pull request with an updated icon that I got from Instagram's own site. The border issue is fixed and it is the exact icon they are pushing at the moment.

On Wed, Jun 24, 2015 at 5:42 AM zimbatm notifications@github.com wrote:

Here is another view of the issue: https://samcollins.github.io/css-social-buttons/src/

— Reply to this email directly or view it on GitHub https://github.com/samcollins/css-social-buttons/pull/81#issuecomment-114854349 .

zimbatm commented 9 years ago

Cheers !