smcmahon / Products.PloneFormGen

PloneFormGen add on for Plone
http://plone.org/products/ploneformgen
Other
31 stars 76 forks source link

Unauthorized Error while rendering email template #80

Open cwx-hannoschulz opened 11 years ago

cwx-hannoschulz commented 11 years ago

After the security update 1.6.7 the three methods getBody_pre, getBody_post and getBody_footer are no longer callable from mail template.

How to Reproduce:

The fields missing in the mail, cause of the "| nothing" in the template field. I've debugged this to the changed security declaration in version 1.6.7.

datakurre commented 11 years ago

It seems that this change was introduced as as Backport docstring/setPrivate fixes from 1.7.9 in https://github.com/smcmahon/Products.PloneFormGen/commit/51695f64d081bb57c62439163e12ddfe0eea6ecb, but there is no exact match for it in 1.7.9.

bobo_traverse-patch in https://github.com/smcmahon/Products.PloneFormGen/commit/de053133678b07e2fedfa44fa59ba28350fc76af looks like the closest match.

Would it be correct to revert declarePrivate from getBody_pre, getBody_post and getBody_footer and add bobo_traverse-patch from https://github.com/smcmahon/Products.PloneFormGen/commit/de053133678b07e2fedfa44fa59ba28350fc76af? Or was there some other reason why the backport was so much different from fixes in 1.7.9?