search

smcvey / tcz

The Chatting Zone Mud Server
GNU General Public License v2.0
6 stars 3 forks source link

Update character.c #60

Closed moeyjar closed 2 years ago

moeyjar commented 2 years ago

Removing Goovy (typo of Groovy) and adding Obtuse in it's place

moeyjar commented 2 years ago

Change looks fine to me, assuming that there's not any issue with displaying the list of feelings due to 'Obtuse' being out of alphabetical order.

Let me test it out on a temp, I was using https://github.com/smcvey/tcz/commit/a0b74e0c5ba67fcca02a55a271694d7cb297406b as a reference which doesn't seem to have much effect on the feeling code, as long as it has a separate number. I just reused Goovy's number to make it easier. (i.e. Angry is number 1 but 6th on @feeling list).

noahmanderson commented 2 years ago

Closing this one as we discussed. We need to test the new binary built from this and I do want to get an answer about whether that affects the alphabetical listing in the @feelings list. Even if it didn't, I'd still want to see this in alphabetical order to match the local style. Lastly, I'd like to see what it looks like to do this: 1) Have the @feeling of goovy for a character under the old binary 2) Shutdown 3) Start back up with new binary -> Does the player correctly update to Obtuse because of the reuse of the ID or are there other problems?