search

smd111 / Gearswap-Skillup

20 stars 34 forks source link

summoning stops working #11

Closed Latravant closed 2 years ago

Latravant commented 6 years ago

summoning magic stops working sometimes and i think i found out why but dont know how to fix it. i noticed when my toon ran out of mp after it cast a summon spell, the lua still tried to use /ja "release" then it just stopped working since there was nothing to release.

madantichris commented 5 years ago

I found this issue as well. The script will fail if you run out of MP between the summon and the release and the avatar fades away on its own. I fixed it in my local copy. I will have to see if I can do a pull request to get the fix up here.

gh0sth4ck3d commented 5 years ago

@madantichris would it be possible to get your fix for this? I am having the same issue.

madantichris commented 5 years ago

@madantichris would it be possible to get your fix for this? I am having the same issue.

I will get my pull request in tonight if possible. If the project owner isn't responsive or interested in maintaining it, I'll fork it.

smd111 commented 5 years ago

unfortunately i cant do anything right now as i only have a Chromebook to use to access the internet right now

but if you want to try and fix it go for it

however smn was the hardest to get to work because of all the things you need to watch

madantichris commented 5 years ago

unfortunately i cant do anything right now as i only have a Chromebook to use to access the internet right now

but if you want to try and fix it go for it

however smn was the hardest to get to work because of all the things you need to watch

@smd111 Pull request 13 is in to fix this. I have tested it fairly extensively on a couple different accounts. https://github.com/smd111/Gearswap-Skillup/pull/13

madantichris commented 5 years ago

@Latravant @gh0sth4ck3d Please pull down the latest script and give it a try. @smd111 has merged my fix into the master branch.

gh0sth4ck3d commented 5 years ago

@madantichris thanks man, will give it a go.

wezzie88 commented 2 years ago

@madantichris @smd111 i know you guys said you dont want to know if issues are found but, im having one and cant find a way to make it work, im casting summoning and its not releasing after the first cast, is there a timer somewhere to increase cause it automatically goes into /Heal mode

Thanks