Closed abettermap closed 7 years ago
@smddzcy I believe this is what you were looking for, but let me know if I missed anything. I also included some brief trips in the readme
. Could maybe integrate your colors instructions into that section as well, if you think that makes sense.
Also, if you approve the merge, beforehand could you please re-apply the hacktoberfest label approving? I am shooting for the DigitalOcean t-shirt and only have one more merge to go. π
@smddzcy Actually disregard the hacktoberfest thing- they actually want four pull requests total and the deadline is tomorrow sooo guess I missed out. Happy I could help anyways though. Neat project!
Thank you so much, you've done very well π
Here are the missing things. I can finish it up but if you want to continue:
px
Β units in LESS/CSS files should be replaced with rem
s. (Only body
should have a pixel unit)font_sizes.json
should contain the default sizes so that user will have an idea.Btw, Hacktoberfest needs 4 pull-requests, not 4 merges, so you still have some chance π
@smddzcy Ha, good to know about the t-shirt, but I think a full day at work and Halloween tonight will prevent any more requests for me. Next year! π
@smddzcy and go ahead with the remaining todos, I probably won't commit anymore unless you find anything else wrong with what I've submitted already.
Closes #2