search

smdogroup / tacs

Finite-element library for analysis and adjoint-based gradient evaluation
Apache License 2.0
108 stars 75 forks source link

Fix issue with delayed transient loads #297

Closed A-CGray closed 8 months ago

A-CGray commented 8 months ago

Prior to version 1.4.0, pyNastran's get_load_at_time was not correctly interpolating transient loads defined using TLOAD1 when a delay was used.

For example, test_trans_beam.py uses a tip load that is supposed to ramp from 0 to 5N over 1 second with a delay of 1 second. Due to the error in pyNastran, the load was instead being applied as a constant 5N from 0 to 1 seconds and 0N from 1 to 2 seconds, resulting in this solution:

Wrong

With pyNastran 1.4.0, the correct solution is: Right

This PR bumps the minimum required pyNastran version to 1.4.0 and updates the reference values for the fixed transient integration test.

A-CGray commented 8 months ago

Sorry @timryanb , just saw this is already addressed by #289 , closing.