search

smebberson / docker-alpine

Docker containers running Alpine Linux and s6 for process management. Solid, reliable containers.
MIT License
596 stars 186 forks source link

Discrepancies between Dockerfiles #10

Closed matthewvalimaki closed 8 years ago

matthewvalimaki commented 8 years ago

alpine-nginx specifies specific nginx version while alpine-consul-nginx does not.

Version should be specified to avoid potential breakage caused by version changes. Latest non-breaking versions available should be used for releases.

It would be nice to note package version changes in change log :)

smebberson commented 8 years ago

@matthewvalimaki, good catch. I'll add this in.

smebberson commented 8 years ago

@matthewvalimaki, as of the later versions of these images, this has all been resolved. nginx is now properly pinned.