search

smebberson / docker-alpine

Docker containers running Alpine Linux and s6 for process management. Solid, reliable containers.
MIT License
596 stars 186 forks source link

Fix #22 by defining user shell with `-s /bin/sh` #23

Closed matthewvalimaki closed 7 years ago

matthewvalimaki commented 8 years ago

Signed-off-by: Matthew Valimaki matthew.valimaki@gmail.com

matthewvalimaki commented 8 years ago

I added -g "" to make the GECOS field be empty so that we wouldn't have :Linux User,,,.

smebberson commented 8 years ago

@matthewvalimaki, has the merge blown away one of the commits? When I view https://github.com/smebberson/docker-alpine/pull/23/files it only shows the change to alpine-consul/Dockerfile, not the change to alpine-rabbitmq/Dockerfile?

matthewvalimaki commented 8 years ago

@smebberson removed my last comment as it made no sense. So it does look like one change was removed for some reason. I'll fix.

smebberson commented 8 years ago

@matthewvalimaki, is this PR still relevant?

smebberson commented 7 years ago

@matthewvalimaki, I'm closing this because I've already incorporated the changes along the way somewhere. Sorry about not merging in your PR :(