search

smebberson / docker-alpine

Docker containers running Alpine Linux and s6 for process management. Solid, reliable containers.
MIT License
596 stars 186 forks source link

#12 #33

Open matthewvalimaki opened 8 years ago

matthewvalimaki commented 8 years ago

Signed-off-by: Matthew Valimaki matthew.valimaki@gmail.com

smebberson commented 8 years ago

@matthewvalimaki, are you able to refactor this PR now that all the changes have been launched? I still think it's a worth while addition.

matthewvalimaki commented 8 years ago

@smebberson yes sir. I'll try to get it done asap. On Jun 9, 2016 4:31 PM, "Scott Mebberson" notifications@github.com wrote:

@matthewvalimaki https://github.com/matthewvalimaki, are you able to refactor this PR now that all the changes have been launched? I still think it's a worth while addition.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/smebberson/docker-alpine/pull/33#issuecomment-225056804, or mute the thread https://github.com/notifications/unsubscribe/AA_GtTes6VeGI1Rs-1KGrMMSsmQv6C_6ks5qKKJhgaJpZM4H3NeZ .

smebberson commented 7 years ago

@matthewvalimaki, I'm going to be making these changes while moving to Node.js v7. I'm going to be releasing all of the 6.x releases I've missed now. Are you willing to refactor this now as there has been a few changes, and then I'll merge this in.

Thanks!

benedikt-roth commented 6 years ago

@smebberson I am looking for a way operate within the container as non-root user. Since this PR seems outdated – can you recommend any best practices for now?

/cc @GauSim