smebberson / docker-alpine

Docker containers running Alpine Linux and s6 for process management. Solid, reliable containers.
MIT License
596 stars 186 forks source link

Consul advertise and client address #45

Closed ncornag closed 8 years ago

ncornag commented 8 years ago

If you have multiple IPs in your container, it's necessary to add -advertise $BIND -client 0.0.0.0 to the run script to be able to connect to it. This modification should not cause any side effect if the containers has only one address, but I think you should test it just in case.

smebberson commented 8 years ago

Yeah okay, that sounds like a sensible default. I'll change that and see how it goes. Thanks for that pickup.

smebberson commented 8 years ago

@ncornag, I've made these changes in the latest commits (https://github.com/smebberson/docker-alpine/blob/alpine-consul-ui-upgrades/alpine-consul/root/etc/services.d/consul/run). They're working well, thanks!