smebberson / docker-alpine

Docker containers running Alpine Linux and s6 for process management. Solid, reliable containers.
MIT License
596 stars 187 forks source link

Unable to use the `run` scripts in each directory under examples/ #83

Closed zaataravi closed 7 years ago

zaataravi commented 7 years ago

Hi, I'm unable to execute any of the run scripts in the examples directory. Am I doing something wrong? Thanks! --ravi.

screen shot 2017-03-31 at 5 16 36 pm

smebberson commented 7 years ago

Have you tried running the build scripts first? Sometimes there is a build script, but if there is a docker-compose.yml file, you need to run docker-compose build from within that directory...

zaataravi commented 7 years ago

Yup, that did it, thank you Scott. I needed to:

mkdir /vagrant/
mkdir /vagrant/examples/
# checkout user-nginx into /vagrant/examples
./build
./run

to make it all work, since the build script relies on finding the code at vagrant/examples.

I am happy to submit a Pull Request to update the README.md file, and potentially fix some issues with the build/run scripts, if you think it is useful. Thx for putting this stuff together!

smebberson commented 7 years ago

Ah, I see, you're not running within Vagrant? Everything is setup and intended to be run through a Vagrant VM...

smebberson commented 7 years ago

@ravi-sensify, this is the guide... https://github.com/smebberson/docker-alpine/blob/master/CONTRIBUTING.md

I think I might need to improve the README though so it's more obvious...

zaataravi commented 7 years ago

Sounds good, I'll take a closer look. No, I'm ripping a bunch of dockers out for my own private use, I didn't realize individual dockers were so tightly coupled with Vagrant itself.

Thanks a ton once again! 👍

smebberson commented 7 years ago

@ravi-sensify, they're not really tightly coupled to Vagrant. Just the development environment and examples are.

If you're planning on using these on your own projects, it's intended that you'll download them from Docker Hub in your Dockerfile as per FROM smebberson/alpine-rabbitmq for example.