smeea / vdb

VTES cards search & deck building & twda search web application
MIT License
20 stars 10 forks source link

Add Set to Cards in Inventory #22

Closed Kynes closed 1 year ago

Kynes commented 2 years ago

It would be amazing if we could, optionally, set to which Set belong the cards in the Inventory. Maybe adding a drop down with only the available Sets for each card in the inventory list, to set how many we have of each set.

Also, that would mean being able to filter by Set in the Inventory list.

The last part would be being able to set to which Set the cards in a Deck belong: I think it would be useful to keep track of cards, but I'm not 100% sure of this. Also, I don't know how this could be shown in the interface without getting in the way.

Thanks a lot for your great effort!

smeea commented 2 years ago

I trust this feature may be useful to some collectioners wanting to Find 'Em All, but it will bring additional complication to UI of inventory-related parts for all users being rather marginally used. I dont see this feature coming anytime soon, unless there will be volunteer to make it really non-invasive (read: completely opt-in on the user-side).

soulcharmer commented 1 year ago

Hi, a Patreon backer here :-)

I fully support this RFE and have a few more scenarios for it:

0) the default one is one's own inventory and the ability to tell which card is which when you have multiples. For example, cards from Berlin Anthology are usually more valuable then later reprints. The same is true for Jyhad cards compared to their 10th anniversary reprints. We also have PoD prints now, further distinguishing the overall VTES stock for players and collectors alike.

1) people are also sharing their inventories for trading - buyers/collectors are often interested only in a specific print that is sometimes associated with a different illustration. With more variations of cards becoming available that include fullart versions, special promos, sketch arts, etc., there will be even more need to distinguish users' inventories (at least for some of them)

2) I'd like to use the VDB inventory (or just a random VDB deck fi possible) for my wantlist - in it, I definitely need to distinguish card versions as I collect art variants and also collect certain sets in favor of others.

Maybe there are options to implement a simplified variant of this feature. Right now, I'm thinking of two options that seems fairly non-invasive to me:

a) the VDB card dialog already includes the list of prints, including their set code and a scan. Could these be reused as optional tags for inventory entries? If so, there could be additional custom tags for "misprint", "signed", "altered", "damaged", etc.

b) If nothing else is viable, could we at least get an optional "Notes" field for inventory items? There, we could specify random details about the cards that would include set, art variants, etc. It would definitely be a viable option for me to do on a relatively small scale and it would hopefully not compromise any existing feature or interfere with any existing code.

Thank you for considering it!

smeea commented 1 year ago

@soulcharmer First, thank you for the support!

The existing approach to everything related to inventory is that each card is not unique at all - i.e. VDB works with card-id and q-ty, and adding "another one" is just incrementation/decrementation of the q-ty => so it is very simple to change card q-ty without considering which card has gone and where (remember cards are not only in inventory they are also tracked inside the decks).

Making each one card an unique (to have it's own properties) is a significant change (in both UI and under the hood), however once it is done the rest of the changes are much simpler to do (in other words: it is not really different to add "only notes" or to make full-blown properties set for the card, but a great step from nothing at all to "only notes").

I don't want to break anyone hopes, but realistically I don't think I will start working on it in any foreseeable future (dont feel at all this can be accomplished in few evenings), there are some also big tasks which are much more important for the VDB user base (or for the future development of the VDB as there are a lot of buggy/messy/deprecated code I'm constantly improving).

soulcharmer commented 1 year ago

Oh, that's unfortunate. I will have to live with it then and just use a deck with all notes in the description as a wantlist for now.

I was hopeful for the feature because I thought that since there are almost no issues filed here on Github and folks are mostly reporting relatively minor issues on Discord, there might be some capacity for new things.

But apparently, the queue is already full. Is it visible somewhere what are your near-future dev priorities? And how, if at all, can the user base interact?

Thank you

Spigushe commented 1 year ago

Honestly, I'm not sure passive-agressive statements will help you have what you want

The implementation of multi-printing is something big and it needs something that needs much thoughts in it.

Overall, I'm in favour of a "better management" thanks to multi-printing. Workload seems really heavy tho.

I'll comply anyway

Le sam. 17 déc. 2022 à 22:35, TCapek @.***> a écrit :

Oh, that's unfortunate. I will have to live with it then and just use a deck with all notes in the description as a wantlist for now.

I was hopeful for the feature because I thought that since there are almost no issues filed here on Github and folks are mostly reporting relatively minor issues on Discord, there might be some capacity for new things.

But apparently, the queue is already full. Is it visible somewhere what are your near-future dev priorities? And how, if at all, can the user base interact?

Thank you

— Reply to this email directly, view it on GitHub https://github.com/smeea/vdb/issues/22#issuecomment-1356476632, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ3IGVDKU5QA4Q5NFUELYDWNYW2BANCNFSM5KPR2KPQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

soulcharmer commented 1 year ago

Honestly, I'm not sure passive-agressive statements will help you have what you want The implementation of multi-printing is something big and it needs something that needs much thoughts in it. Overall, I'm in favour of a "better management" thanks to multi-printing. Workload seems really heavy tho. I'll comply anyway

Excuse me?

@smeea made it clear that card properties are not coming in the near future and I conceded to work around the problem.

From my experience, an empty ticket queue usually indicates free capacity. As I was apparently wrong, I am merely curious what is coming for VDB and how to keep in touch...

smeea commented 1 year ago

Let me be clear: VDB is my pet project and "capacity" is not something really applied to the development process :)

And since most VTES/VDB users are not developers, github issues is not very active, so for the issues in the "queue" is better to refer to ~/TODO.md (it is not very structured/descriptive as it is intended for internal use just be remind me about items, and not like full task explanation for "the team").

lionel-panhaleux commented 1 year ago

I can see the value of the kind of ideas @soulcharmer is discussing. Not sure I'd use such features, but I might. I can also see why we wouldn't to make each card "different" from an abstraction perspective.

Maybe you could consider adding a set of extra attributes to stack of cards? ie. I have 23 carrion crows, maybe an extra attribute on "carrion crows" in general (not any single copy) that could be used (if the user want) to indicate things (like noting 2 of them are Jyhad), maybe notes like "2 damaged, 1 signed". Sounds like it could be done with an additional property for the whole stack of cards (attributes would apply to the whole stack of carrion crows), not any one card in particular.

That could be enough to have filters/views on the inventory to see if you have a full Jyhad set for example.

smeea commented 1 year ago

Added custom inventory notes for card in d2898ee (while that's not exactly what asked in this issue, I don't intend other set-related solutions).

soulcharmer commented 12 months ago

Thank you for implementing the feature - even though it is fairly basic, I think it is sufficient, except for one thing:

I started to add notes to my inventory but then realized there's no way to recognize which cards have notes and which do not, from the Inventory list view. Without it, having hundreds of inventory items, it seems very impractical to have to remember where the notes are or opening cards one by one to find them after a while...

In both the Library and Crypt inventory panes, there's seems to be enough space (at least on desktop which I use) to add some indication a particular entry has a note. Just the note icon and a short prefix from the note would suffice.

A cherry on top could be an additional filter, Sort by Note....

Would you please consider to expose note data in the primary GUI for the Inventory?