smeerten / ssnake

A program for the analysis of NMR data.
Other
19 stars 15 forks source link

LorentzST entries and related checkButtons disabled if satellites checkButton unchecked #113

Closed jtrebosc closed 2 years ago

jtrebosc commented 2 years ago

There are 2 commits: 1) the LorentzST entries are disabled if satellite checkButton in not checked. This also prevent trying to fit this parameter: the checkButton is setChecked and disabled as well as the column checkButton. This commit also modify the column checkButtons for Cq0 and eta0 in Czjzek model. Indeed, switching between extended/normal mode was disabling each site checkButton. But the global column checkButton was not disabled. This made possible to uncheck the site checkButtons... 2) I factorized the population of site entries and checkButton through a function in the Abstract class. I added a MULTINAMES_ORDER that can possibly be used to reorder the column order of these parameter (in a preference setting for example). I did not implement such feature though that requires some update function. I updated all the model to use that function. One point is a bit unclear to me : in the relaxation model the entries are initialized with a rounded value: ('%#.' + str(self.rootwindow.tabWindow.PRECIS) + 'g') % self.fitParamList[locList][self.MULTINAMES[j]][i][0]). The other models don't do that, neither do my populate function. However I believe this is not an issue as it is probably done at a later step. Such change also affects the addMultiLabel function that doesn't need anymore the num argument. I believe that change makes the whole code easier to maintain.

Best regards, Julien