Allow passing options to delete

smeevil / cloudex

An elixir library which helps with uploading image files or urls to cloudinary

Do What The F*ck You Want To Public License

103 stars 64 forks source link

Allow passing options to delete #60

Closed tonnenpinguin closed 4 years ago

tonnenpinguin commented 5 years ago

In order to delete for example private images as well we need to be able to pass options to the delete function.

This PR implements this behaviour and can be used like so:

Cloudex.delete(public_id, %{resource_type: "image", type: "private"})

As returning the DeletedImage struct without feedback whether the delete was actually successful makes figuring out what's going wrong quite hard I've also added the http response to DeletedImage

coveralls commented 5 years ago

Coverage increased (+0.5%) to 85.616% when pulling c0b3f8faaaea104fdafd10836109ffb1f312a54d on dino-keskic:master into 2d37b913ac55b28bece4c4b3a470cc4607490716 on smeevil:master.

smeevil commented 4 years ago

Hi,

Sorry for the absurd long response time :/ Today I went through the open pull request but in reversed order, this resulted in a conflict.

If you like to resolve those, I'll make sure it will be merged in this time ;)

tonnenpinguin commented 4 years ago

Closing this in favour of #65