codepathreview
commented
8 years ago Decent submission, consider adding more challenging optional stories. A few notes after checking out the code:
- Good to see you were able to format the timestamp cleanly (consider using the short format -
8m,7h, etc.) - Good to see you refreshed the timeline after composing a new tweet
- Nice touch with the character count being displayed while the user composes a tweet
- Nice to see you used a
SwipeRefreshLayoutlibrary for easy timeline refreshes - Consider adding progress bars to your app whenever a network request goes out
Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.
App is good to go, please review. /cc @codepathreview @codepath
Had a good time with this project. Decided to just start off with Butterknife and I'm glad I did - will be using that or data-binding from now on. Everything went smoothly, except for ActiveAndroid. It wasn't able to find my table definitions without me explicitly giving it the paths to the models in the manifest. After that, another re-install had it up and running.